ci: netlify - Standardise package manager and runtime configuration #4

CI Summary

Standardise npm configuration and align nested Netlify settings with the existing Node.js 24 requirement. Configuration changes are committed in ci: netlify - Standardise package manager and runtime configuration; deployment acceptance remains outstanding.

Linked Stories/Tasks/PRs/Epic

Related implementation: #341. No related epic identified.

Milestones & Timeline

Estimate L, retained from existing prose; no structured estimate set. No milestone or deadline supplied.

Steps / Checklist

Checked items describe committed work, not deployment completion.

• Scope and checklist defined.
• pnpm lockfile, workspace configuration and Vite override removed; no replacement npm override introduced.
• Nested Netlify settings aligned to npm, Node 24 and npm 10.
• README/changelog updates committed.
• Existing ci/ branch passed branch validation.
• Changelog formatting follow-up committed; previous review thread resolved.
• Complete validation and maintainer review below.

Acceptance Criteria

• Existing npm lockfile, Node 24 requirement and Vite requirement preserved.
• CI locked installation with lifecycle scripts disabled succeeded on Node 24.21.0/npm 11.19.0; 588 Jest tests passed.
• Record lifecycle-enabled npm ci, npm run build, npm run journal:validate and npm run journal:check-links on the intended runtime, distinguishing existing warnings from regressions.
• Verify effective Netlify configuration, Node/npm versions, build command, publish target and successful deploy preview.
• Applicable CI passes and build/deployment validation demonstrates no regressions.

Additional Context

Closure caveat: A commit in PR #341 contains Resolves #4, although the PR description uses Relates to #4. Verify whether GitHub issue #4 was automatically closed and whether that affected the synced Linear status. Merge or automatic closure does not demonstrate completion of the outstanding acceptance criteria.

Supplied audit. Reported findings, not independently verified here. Full build logs were inaccessible to the auditor; browser, accessibility and Lighthouse testing not performed. Audit applied no changes.

Definition of Ready (DoR)

• Build/CI goal and scope defined.
• Work-specific checklist prepared.
• Existing written estimate L recorded; no structured estimate asserted.

Definition of Done (DoD)

• All acceptance criteria verified.
• At least one maintainer approval recorded and review concerns resolved.
• Documentation accurately reflects verified configuration and validation.
• PR merged and branch deleted.
• Issue closed only after acceptance.
• Related epic update: not applicable; none identified.

Implementation evidence

• pnpm-lock.yaml and pnpm-workspace.yaml are deleted.
• package.json removes the pnpm override; Vite ^6.4.3 remains unchanged.
• .nvmrc already contained 24; package-lock.json is unchanged. No root .node-version or netlify.toml exists.
• src/app/netlify.toml requests npm run build, Node 24/npm 10; publish target remains dist. Effective Netlify configuration is unverified.
• README.md and CHANGELOG.md are updated, but some deployment/migration claims exceed the committed evidence.
• CI installation and Jest results are verified. Local installation/build/journal passes are author-reported, not independently rerun. Earlier research used a modified lockfile.
• Outstanding failures concern the comparison module, changelog check publication and labelling clone step. The previous changelog review thread is resolved; fresh CodeRabbit review is pending.

Unanswered clarification questions

These questions clarify outstanding acceptance; committed configuration or automatic issue closure does not establish deployment success.

1. What evidence confirms the effective Netlify configuration, runtime, build command and publish directory for the intended deployment?
2. What results demonstrate the existing lifecycle-enabled installation, build and journal-validation requirements on that runtime?
3. Which applicable CI failures are regressions, pre-existing failures or accepted limitations?
4. Did the recorded closing reference in PR ci: netlify - Standardise package manager and runtime configuration #341 affect GitHub issue ci: netlify - Standardise package manager and runtime configuration #4 or its synced Linear status, and how should that be distinguished from acceptance?
5. Who accepts the deploy-preview evidence and confirms that maintainer-review concerns are resolved?