Repository navigation
feat: add Octolens keyword-mapping DAL (CM-1834) - #4891
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
…-dal Signed-off-by: Uroš Marolt <uros@marolt.me>
PR SummaryLow Risk Overview The module exposes find, list, add, and remove helpers against Reviewed by Cursor Bugbot for commit c26fe1c. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The DAL matches the table constraints, uses established query patterns, and has adequate integration coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the Octolens keyword-mapping DAL with tested CRUD operations and package exports.
Changes:
- Adds find, list, add, and remove functions.
- Covers CRUD behavior and unique-constraint conflicts.
- Exports the Octolens DAL publicly.
| File | Description |
|---|---|
src/octolens/index.ts |
Implements keyword-mapping queries. |
src/octolens/index.test.ts |
Tests query behavior and constraints. |
src/index.ts |
Exports the Octolens module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gaspergrom
left a comment
There was a problem hiding this comment.
LGTM. Column names and types in the queries match the CM-1833 migration, and the (integrationId, keywordId) unique constraint backs both the find lookup and the duplicate-insert test. Tests cover find, list, add, remove, and the conflict case.
Summary
Data access for Octolens ingestion: DAL functions over the
octolensKeywordMappingstableadded in CM-1833. Second half of the original CM-1834 unit — the platform enums and
mentionactivity type shipped already in #4889.
Changes
services/libs/data-access-layer/src/octolens/:findOctolensKeywordMapping,listOctolensKeywordMappings,addOctolensKeywordMapping,removeOctolensKeywordMappingindex.tsindex.test.tscovering find/list/add/remove, including the(integrationId, keywordId)unique-constraint conflictType of change
JIRA ticket
https://linuxfoundation.atlassian.net/browse/CM-1834