Skip to content

power: Add sysfs and logind fallback for keyboard and display backlight #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DerLinke wants to merge 2 commits into from
Closed

power: Add sysfs and logind fallback for keyboard and display backlight #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613aa4b
power: Add sysfs and logind fallback for keyboard and display backlight
Oct 14, 2026
86586d2
meson.build: Add prefix include directory to compiler arguments
Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ version = meson.project_version()
pkgname = meson.project_name().to_lower()
api_version = '3.0'

cc = meson.get_compiler('c')
cargs = []

# directories
prefix = get_option('prefix')

cargs = [
'-I' + join_paths(prefix, 'include'),
'-I' + join_paths(prefix, 'usr', 'include'),
]
bindir = get_option('bindir')
datadir = get_option('datadir')
libdir = get_option('libdir')
Expand Down
50 changes: 38 additions & 12 deletions plugins/power/csd-backlight-helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,30 @@

#define CSD_POWER_SETTINGS_SCHEMA "org.cinnamon.settings-daemon.plugins.power"

static gboolean
csd_backlight_helper_device_is_valid (GUdevDevice *device)
{
const gchar *sysfs_path;
gchar *max_path;
gchar *contents = NULL;
gboolean valid = FALSE;

sysfs_path = g_udev_device_get_sysfs_path (device);
if (sysfs_path == NULL)
return FALSE;

max_path = g_build_filename (sysfs_path, "max_brightness", NULL);
if (g_file_get_contents (max_path, &contents, NULL, NULL)) {
gint64 max_val = g_ascii_strtoll (contents, NULL, 10);
if (max_val > 0)
valid = TRUE;
g_free (contents);
}
g_free (max_path);

return valid;
}

static gchar *
csd_backlight_helper_get_type (GList *devices, const gchar *type)
{
Expand All @@ -47,7 +71,7 @@ csd_backlight_helper_get_type (GList *devices, const gchar *type)

for (d = devices; d != NULL; d = d->next) {
type_tmp = g_udev_device_get_sysfs_attr (d->data, "type");
if (g_strcmp0 (type_tmp, type) == 0)
if (g_strcmp0 (type_tmp, type) == 0 && csd_backlight_helper_device_is_valid (d->data))
return g_strdup (g_udev_device_get_sysfs_path (d->data));
}
return NULL;
Expand All @@ -58,27 +82,29 @@ csd_backlight_helper_get_best_backlight (gchar** preference_list)
{
gchar *path = NULL;
GList *devices;
GList *d;
GUdevClient *client;

client = g_udev_client_new (NULL);
devices = g_udev_client_query_by_subsystem (client, "backlight");
if (devices == NULL)
goto out;

/* setup our gsettings interface */
if (preference_list == NULL || preference_list[0] == NULL) {
g_print("%s\n%s\n",
"Warning: no backlight sources have been configured.",
"Check " CSD_POWER_SETTINGS_SCHEMA " to configure some.");
goto out;
if (preference_list != NULL && preference_list[0] != NULL) {
int i = 0;
for (i = 0; preference_list[i] != NULL; i++) {
path = csd_backlight_helper_get_type (devices, preference_list[i]);
if (path != NULL)
goto out;
}
}

int i = 0;
for (i=0; preference_list[i] != NULL; i++) {
path = csd_backlight_helper_get_type
(devices, preference_list[i]);
if (path != NULL)
/* Fall back to any valid backlight device */
for (d = devices; d != NULL; d = d->next) {
if (csd_backlight_helper_device_is_valid (d->data)) {
path = g_strdup (g_udev_device_get_sysfs_path (d->data));
goto out;
}
}

out:
Expand Down
Loading