Repository navigation
Mint-Y/cinnamon: Style CheckBox2 (.check-box-2) - #559
Open
ogzhntutucu wants to merge 1 commit into
Open
ogzhntutucu wants to merge 1 commit into
ogzhntutucu wants to merge 1 commit into
Conversation
Cinnamon's CheckBox2 widget (style class `check-box-2`, used by the keyring unlock prompt in js/ui/keyringPrompt.js) has no style in Mint-Y, so the check box indicator is invisible: only the label is shown, and clicking the label silently toggles the hidden box. Mint-X and Cinnamon's default theme already style it. Reuse the existing `.check-box` rules for `.check-box-2` and add spacing between the indicator and the label, since CheckBox2 uses an St.BoxLayout instead of a CinnamonGenericContainer. Regenerate the css files with parse-sass.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cinnamon's CheckBox2 widget (style class
check-box-2, used by thekeyring unlock prompt in js/ui/keyringPrompt.js) has no style in Mint-Y,
so the check box indicator is invisible: only the label is shown, and
clicking the label silently toggles the hidden box. Mint-X and Cinnamon's
default theme already style it.
This reuses the existing
.check-boxrules for.check-box-2and addsspacing between the indicator and the label, since CheckBox2 uses an
St.BoxLayout instead of a CinnamonGenericContainer. The css files were
regenerated with parse-sass.sh.
Tested on Linux Mint 22.3 (Cinnamon) with Mint-Y-Dark-Red: the
"Automatically unlock this keyring whenever I'm logged in" check box is
now visible and toggles correctly.