Cannot pass in decomb=bob

[lambdan]

From HandBrakeCLI --help:

-5, --decomb[=string]   Deinterlace video using a combination of yadif,
                           blend, cubic, or EEDI2 interpolation.
                           Presets:
                               bob
                               eedi2
                               eedi2bob
                           Custom Format:
                               mode=m:magnitude-thresh=m:variance-thresh=v:
                               laplacian-thresh=l:dilation-thresh=d:
                               erosion-thresh=e:noise-thresh=n:
                               search-distance=s:postproc=p:parity=p
                           Default:
                               mode=7

So I figured -x decomb=bob would work, but nope. It results in --decomb bob being passed to HandBrakeCLI.

I manually worked around this by throwing a options += ['--decomb=bob'] into the ruby script, so it's not a big deal but maybe you want to know about it anyway.

EDIT: Same with --deinterlace=bob

[lisamelton]

@lambdan Thanks for opening this issue! My apologies for the problem. And, sadly, I did already know about it 🤦‍♀️, but I just haven't fixed it yet. Fixing it correctly is actually more complicated than I thought.

[lisamelton]

@lambdan I didn't merge @crkochan's patch but instead committed and pushed a completely different change to fix this. It's in the source tree right now if you want to try it out. I'll likely make an official release during the upcoming week.

[lambdan]

@lisamelton haven't tested but I'm sure it will work.

Though I must admit I prefer the @crkochan approach because it's more general and hasn't hardcoded the options.

I don't know how often Handbrake adds new options, but let's pretend they add a new revolutionary option that takes a value, and everyone wants to try and use it immediately, the transcode-video user will either have to edit it locally to add that option or wait for an update to it if they don't know how (though I imagine a person who follows HandbrakeCLI changes is likely to know how to fix it 😅)

[lisamelton]

@lambdan The problem with that generalized approach is it also changed the behavior for all other --extra options. While the risk was low that would adversely affect output, I didn't want to take that chance. I also didn't like the aesthetics of the output on the command line. But maybe I'm weird that way. 😂 And there were other changes in the patch that I didn't want to take either, some having little if anything to do with the actual bug fix. 🤷‍♀️

So, you're stuck with my solution unless you want to patch it yourself. 😉 As for my fix, it has the advantage of being contiguous and completely isolated. And it's boringly easy to adjust if HandBrakeCLI gets updates adding more of their screwy options which don't follow their other rules.

Since most of the recent changes to the HandBrakeCLI don't have additions like that, I don't think it's gonna be a problem. I'm much more concerned about future changes to the actual encoding functionality and if the developers, once again, change the text output of their tool which I'm doomed to parse.

Anyway, I'll close this issue when I make an actual release later this week.

Thanks for your feedback! And, once again, my apologies for taking so long to fix this. 🤦‍♀️ My thanks to @crkochan for giving me a reason to get off my ass and take a break from all the game development I'm doing now. 💖