Repository navigation
LK Capture integration - #276
stephen-derosa wants to merge 27 commits into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
a21d2ec to
4c67c5a
Compare
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
5 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
1f16247 to
31d42b2
Compare
…ope of the public API WRT capture.
…/build.rs file Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
29ddf8f to
a990fad
Compare
| key: ${{ matrix.os }}-${{ matrix.name }}-cargo-target-v3-${{ steps.rust_sha.outputs.sha }} | ||
| restore-keys: | | ||
| ${{ matrix.os }}-${{ matrix.name }}-cargo-target- | ||
| ${{ matrix.os }}-${{ matrix.name }}-cargo-target-v3- |
There was a problem hiding this comment.
Wasn't this v2 the last time I looked? I guess I'm still fuzzy on the need for a new key format here?
Sounds like from another comment a new hash is being integrated into this, can you elaborate on that?
There was a problem hiding this comment.
so v2 added the relocated Windows Cargo output path and v3 switched to caching both standard and capture builds together, avoiding an exact hit on v2 caches.
tbh im a little confused on why we are versioning these in the first place. Chat was explaining it as denoting when a new rust cache is created, but im not understanding why this is needed.
There was a problem hiding this comment.
I'd see if we can roll this back or get further clarity to why we can't re-use this key. I'm assuming folder structure changed but I wouldn't think that was a blocker, given the hash change it would be invalidated anyway?
There was a problem hiding this comment.
i went with a slightly new path for caching -- instead of a manual v1/2/3/*, we caches by platform, build type, build-configuration hash, and Rust commit. https://github.com/livekit/client-sdk-cpp/pull/276/changes#diff-a76cf7978f0a981f911e8d68d2351a72a268977304612226433df4fb8203b06fR144
|
todo: cherry-pick Done |
#227 minus device capture source and addressing comments.
This implementation assumes that the livekit capture build is behind a build arg which would bring in gstreamer deps (very large)