Skip to content

BOT-575: Deprecate Intel macOS runners - #283

Open
stephen-derosa wants to merge 2 commits into
mainfrom
sderosa/BOT-575-deprecate-mac-intel-x86_64
Open

stephen-derosa wants to merge 2 commits into
mainfrom
sderosa/BOT-575-deprecate-mac-intel-x86_64

Conversation

@stephen-derosa

@stephen-derosa stephen-derosa commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Deprecate Intel macOS CI runners and release bundles. macOS builds, unit/integration/stress tests (including nightly runs through the reusable test workflow), and releases now run only on Apple Silicon.

  • Remove macos-x64 from the build, test, and release matrices and release archive list.
  • Remove Intel-only Rust target installation and architecture overrides.
  • Remove Intel macOS from the supported platform list.

Validation: actionlint v1.7.12 passed for all three modified workflows (ShellCheck disabled); git diff --check passed. SDK builds and integration tests were not run for these CI changes.

BOT-575

@stephen-derosa
stephen-derosa requested review from a team and xianshijing-lk as code owners October 13, 2026 17:21
Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Comment thread AGENTS.md Outdated
Comment thread docs/building.md Outdated
@stephen-derosa stephen-derosa changed the title BOT-575: Deprecate Intel macOS runners BOT-575: Deprecate Intel macOS runners and remove legacy Linux bundles Oct 13, 2026
@stephen-derosa stephen-derosa changed the title BOT-575: Deprecate Intel macOS runners and remove legacy Linux bundles BOT-575: Deprecate Intel macOS runners Oct 14, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review

@devin-ai-integration devin-ai-integration Bot Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Linux alias artifacts cannot support CMake consumers

Downloading either livekit-sdk-linux-* artifact yields build-tree files without the installed CMake package. Consumers using find_package(LiveKit CONFIG) cannot load the SDK from these aliases.

Learn more

The Ubuntu build installs a complete bundle under sdk-out/livekit-sdk-${{ matrix.name }} through install_bundle. The bundle check verifies its CMake config and build metadata, but the aliases upload only raw build-release/lib, include, and bin. The installed lib/cmake/LiveKit and share/livekit/build-info.json are absent from those alias downloads. Both architecture aliases use the same pattern.

Example: A consumer downloads livekit-sdk-linux-x64 and sets CMAKE_PREFIX_PATH to its extracted directory. find_package(LiveKit CONFIG REQUIRED) fails because there is no lib/cmake/LiveKit/LiveKitConfig.cmake; the Ubuntu-named SDK artifact contains it.

Recommended fix: Upload the verified installed sdk-out/livekit-sdk-${{ matrix.name }} bundle under each legacy alias name, just as the primary artifact step does. Check both alias downloads for the CMake config and build metadata.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@stephen-derosa
stephen-derosa force-pushed the sderosa/BOT-575-deprecate-mac-intel-x86_64 branch from 8c51aea to 7f9ef7b Compare October 14, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants