Repository navigation
BOT-575: Deprecate Intel macOS runners - #283
stephen-derosa wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
There was a problem hiding this comment.
🟡 Linux alias artifacts cannot support CMake consumers
Downloading either livekit-sdk-linux-* artifact yields build-tree files without the installed CMake package. Consumers using find_package(LiveKit CONFIG) cannot load the SDK from these aliases.
Learn more
The Ubuntu build installs a complete bundle under sdk-out/livekit-sdk-${{ matrix.name }} through install_bundle. The bundle check verifies its CMake config and build metadata, but the aliases upload only raw build-release/lib, include, and bin. The installed lib/cmake/LiveKit and share/livekit/build-info.json are absent from those alias downloads. Both architecture aliases use the same pattern.
Example: A consumer downloads livekit-sdk-linux-x64 and sets CMAKE_PREFIX_PATH to its extracted directory. find_package(LiveKit CONFIG REQUIRED) fails because there is no lib/cmake/LiveKit/LiveKitConfig.cmake; the Ubuntu-named SDK artifact contains it.
Recommended fix: Upload the verified installed sdk-out/livekit-sdk-${{ matrix.name }} bundle under each legacy alias name, just as the primary artifact step does. Check both alias downloads for the CMake config and build metadata.
Was this helpful? React with 👍 or 👎 to provide feedback.
8c51aea to
7f9ef7b
Compare
Deprecate Intel macOS CI runners and release bundles. macOS builds, unit/integration/stress tests (including nightly runs through the reusable test workflow), and releases now run only on Apple Silicon.
macos-x64from the build, test, and release matrices and release archive list.Validation: actionlint v1.7.12 passed for all three modified workflows (ShellCheck disabled);
git diff --checkpassed. SDK builds and integration tests were not run for these CI changes.BOT-575