Repository navigation
(PART 2) Renames old livekit-uniffi builds to use ffi instead post livekit-ffi / livekit-uniffi merge
#1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| livekit-ffi: minor | ||
| --- | ||
|
|
||
| Rename the published UniFFI packages to an FFI identity. | ||
|
|
||
| Following the `livekit-uniffi` merge, the packages built from | ||
| `livekit-ffi/core-modules` are named after the crate that now produces them. No | ||
| compatibility aliases are published. | ||
|
|
||
| | | was | now | | ||
| |---|---|---| | ||
| | Swift package / product | `LiveKitUniFFI` | `LiveKitFFI` | | ||
| | Swift FFI module | `RustLiveKitUniFFI` | `RustLiveKitFFI` | | ||
| | Maven artifact | `io.livekit:livekit-uniffi-android` | `io.livekit:livekit-ffi-android` | | ||
| | Kotlin package | `io.livekit.uniffi` | `io.livekit.ffi` | | ||
| | pub.dev package | `livekit_uniffi` | `livekit_ffi` | | ||
| | UniFFI namespace | `livekit_uniffi` | `livekit_ffi` | | ||
|
|
||
| **Breaking for the Swift, Android and Flutter SDKs.** Imports, dependency | ||
| coordinates and the generated module names all change together. | ||
|
|
||
| The Swift xcframework continues to be hosted at | ||
| `livekit/livekit-uniffi-xcframework`; only the package and product names inside | ||
| it change. Versions continue from the merged crate, so no published version | ||
| goes backwards within a name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 First Dart release cannot publish
When a release first publishes
livekit_ffi, the automated pub.dev publish fails. The manual first publish and automated-publishing settings forlivekit_uniffido not carry over to the new package.Learn more
The package name in the generated pubspec comes from
DART_PACKAGE_NAMEvia the pubspec template. The release job immediately runsdart pub publish --forcefor that name. pub.dev's initial manual publish and automated publishing configuration belong to an individual package identity; the workflow's bootstrap note describes the old package, not the new one. Without a manual first version and new automated publishing setup, the first tag-push publication cannot succeed.Example: A tag for version
0.12.83generatesname: livekit_ffi. The release job authenticates through OIDC and tries to publish that package, but pub.dev has only been set up to automatelivekit_uniffi; the new package is not published.Recommended fix: Bootstrap
livekit_ffiwith a manual first publication, configure its own pub.dev automated publishing forlivekit-ffi/v{{version}}, and update the workflow's bootstrap instructions before enabling the new package's automated release.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hiroshihorie Do you think it's worth creating a new pub.dev package called
livekit_ffihere, or should I keep the package name in this one spotlivekit_uniffi?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its fine to create a new one 🙂