Repository navigation
Advertise pass-through video formats without requiring a local real e… #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| webrtc-sys: patch | ||
| libwebrtc: patch | ||
| livekit: patch | ||
| livekit-ffi: patch | ||
| --- | ||
|
|
||
| Advertise pre-encoded pass-through video formats even when no local encoder implements the codec, so pre-encoded H.265 publishes negotiate on machines without a hardware HEVC encoder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Raw senders negotiate unusable codecs
GetSupportedFormatsadvertises pass-through-only codecs to raw senders. Untagged encoder creation excludesPreEncoded, so negotiation succeeds but the sender cannot encode.Learn more
Encoder capabilities apply to every sender created by this peer connection factory. They do not carry the sender's later
VideoEncoderBackendchoice. These added formats are also untagged, while Create deliberately excludesPreEncodedfrom automatic fallback. The factory therefore promises support for formats that ordinary raw senders cannot instantiate.Example: On a desktop without HEVC encoding, the factory advertises H.265. A raw sender can negotiate H.265 from that capability, but untagged
Createskips the pass-through factory and returns null instead of an encoder.Recommended fix: Preserve pass-through-only codecs without exposing them as ordinary encoder capabilities. Associate them with explicit
PreEncodedselection before codec negotiation, or add sender-level capability filtering so only pre-encoded publications advertise them. Keep raw sender capabilities limited to formats accepted by untaggedCreate.Was this helpful? React with 👍 or 👎 to provide feedback.