Skip to content

Ship dSYMs in the Swift xcframework again #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pblazej merged 2 commits into from
Oct 19, 2026
Merged

Ship dSYMs in the Swift xcframework again #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac04d15
Ship dSYMs in the Swift xcframework again
pblazej Oct 15, 2026
d768d75
Install cargo-swift by rev, not by probe
pblazej Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/uniffi_swift_dsyms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
livekit-uniffi: patch
---

Embed per-slice `.dSYM` bundles in the Swift `RustLiveKitUniFFI.xcframework` again so Xcode archives and crash symbolication can resolve Rust frames (livekit/client-sdk-swift#1149).
15 changes: 10 additions & 5 deletions livekit-uniffi/Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,16 @@ SPM_PLATFORMS = { value = "macos ios maccatalyst visionos tvos", condition = { e

[tasks.swift-xcframework]
private = true
install_crate = { crate_name = "cargo-swift", binary = "cargo-swift", test_arg = "--help" }
# Multi-crate framework fix, on the fork's `fix/multi-crate-framework` branch
# (open upstream as antoniusnaumann/cargo-swift#101).
install_crate_args = ["--git", "https://github.com/livekit/cargo-swift.git", "--rev", "439269c4ff5097bcca7a0a7588f1adebd95edc06"]
script_runner = "@shell"
script = """
# Not cargo-make's install_crate: that only probes `cargo-swift --help`, so a
# cached binary from an older rev passes. `cargo install` compares the recorded
# source+rev: fast no-op on a match, reinstall on a mismatch.
# Multi-crate framework fix (`fix/multi-crate-framework`, open upstream as
# antoniusnaumann/cargo-swift#101) plus `--debug-symbols` (`feature/dsyms`
# rebased on top, livekit/cargo-swift#4).
cargo install --git https://github.com/livekit/cargo-swift.git --rev c92be034d15129321fb08da0416df4b376930748 --locked cargo-swift

export IPHONEOS_DEPLOYMENT_TARGET=13.0
export MACOSX_DEPLOYMENT_TARGET=10.15
export TVOS_DEPLOYMENT_TARGET=17.0
Expand All @@ -355,7 +359,8 @@ $platform_flags \
--lib-type dynamic \
--privacy-manifest ${SUPPORT_DIR}/swift/PrivacyInfo.xcprivacy \
--exclude-arch x86_64-apple-tvos \
${SWIFT_RELEASE_FLAG}
${SWIFT_RELEASE_FLAG} \
${SWIFT_DSYMS_FLAG}
"""

# Format the generated bindings with swiftformat's default rules. UniFFI's
Expand Down
Loading