Repository navigation
livekit-protocol: the thread schema #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| livekit-protocol: patch | ||
| livekit: patch | ||
| livekit-api: patch | ||
| livekit-capture: patch | ||
| livekit-common: patch | ||
| livekit-data-stream: patch | ||
| livekit-datatrack: patch | ||
| livekit-ffi: patch | ||
| livekit-rpc: patch | ||
| livekit-signaling: patch | ||
| livekit-token: patch | ||
| livekit-uniffi: patch | ||
| --- | ||
|
|
||
| `livekit-protocol` exposes the conversation schema of a thread's database, as protocol's Go package | ||
| does: `agent::THREAD_SCHEMA_VERSION` and `agent::THREAD_SCHEMA_V1` (the SQL); the crates that | ||
| depend on it follow its bump. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Dependent crate bumps missing from changeset
When
livekit-protocolchanges, this changeset omits its dependent crates. The changeset check requires their bumps and fails the PR.Learn more
The changeset check computes the transitive closure of knope-managed packages depending on each changed crate in detect. Multiple managed workspace crates depend on
livekit-protocol, includinglivekit-api,livekit-token,livekit,livekit-ffi, andlivekit-uniffi. Listing only the protocol crate leaves these required bumps missing, and the check exits with failure.Example: A change to lib.rs affects
livekit-apithrough its workspace dependency. The check requires both crates, but finds onlylivekit-protocol: patchin this changeset.Recommended fix: Run the changeset detection script with cargo available and add every reported
missingknope-managed crate to the front matter with the appropriate bump.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to add livekit-api to this changeset