Skip to content

fix(signaling): retain unacknowledged queueable requests #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allenrchan wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(signaling): retain unacknowledged queueable requests #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cccc108
fix(signaling): retain unacknowledged queueable requests
allenrchan Oct 17, 2026
7058c60
docs: include downstream signaling patch releases
allenrchan Oct 17, 2026
0373740
fix(signaling): retain writer receipts across caller cancellation
allenrchan Oct 17, 2026
20b79f7
ci: retain macOS reconnection crash reports
allenrchan Oct 17, 2026
7986896
ci: observe later test targets after an earlier failure
allenrchan Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/retain-queueable-signals-after-write-failure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
livekit: patch
livekit-api: patch
livekit-capture: patch
livekit-ffi: patch
livekit-signaling: patch
---
Retain failed and unattempted queueable signals in FIFO order until a transport acknowledges them, preserving acknowledgements across caller cancellation so successful writes are not replayed on the same connection or after reconnecting.
17 changes: 17 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,15 @@ jobs:
# TODO: Remove once this is enabled by default.
enable_participant_data_blob: true
- name: Test
id: tests
env:
RUST_LOG: info
shell: bash
run: |
# Keep the job failed, but observe later test binaries too. An earlier
# data-track failure must not hide native reconnection crash reports.
cargo test --verbose \
--no-fail-fast \
--target ${{ matrix.target }} \
--features __lk-e2e-test \
-- \
Expand All @@ -193,3 +197,16 @@ jobs:
run: |
cargo build --verbose --target ${{ matrix.target }} -p livekit-net --features uniffi
cargo build --verbose --target ${{ matrix.target }} -p livekit-net --features uniffi,native

# Preserve the failing test and collect only this native test process's
# OS crash reports, never a process-memory core or unrelated host logs.
- name: Upload macOS reconnection crash reports
if: ${{ failure() && runner.os == 'macOS' && steps.tests.outcome == 'failure' }}
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: reconnection-crash-reports-${{ matrix.target }}
path: |
~/Library/Logs/DiagnosticReports/reconnection_test*.ips
~/Library/Logs/DiagnosticReports/reconnection_test*.crash
if-no-files-found: warn
retention-days: 7
Loading
Loading