Skip to content

Require goldenimage for mesh shader tests - #1584

Open
joaosaffran wants to merge 1 commit into
users/joaosaffran/lavapipe-gallivm-assert-1553from
users/joaosaffran/meshshader-goldenimage
Open

joaosaffran wants to merge 1 commit into
users/joaosaffran/lavapipe-gallivm-assert-1553from
users/joaosaffran/meshshader-goldenimage

Conversation

@joaosaffran

@joaosaffran joaosaffran commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The mesh shader tests compare against golden images, so they must require goldenimage.

Fix: #1555

@joaosaffran joaosaffran added the test-lavapipe Run lavapipe tests, only label Oct 14, 2026
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 8d82438 to a1cdc03 Compare October 14, 2026 00:30
@joaosaffran
joaosaffran changed the base branch from users/joaosaffran/lavapipe-access-violation-1552 to users/joaosaffran/lavapipe-rt-sbt-alignment-1561 October 14, 2026 00:30
@joaosaffran
joaosaffran added this pull request to stack #1582 October 14, 2026 00:30
@joaosaffran
joaosaffran removed this pull request from stack #1582 October 14, 2026 00:42
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from a1cdc03 to 9ef728c Compare October 14, 2026 00:42
@joaosaffran
joaosaffran changed the base branch from users/joaosaffran/lavapipe-rt-sbt-alignment-1561 to users/joaosaffran/lavapipe-gallivm-assert-1553 October 14, 2026 00:42
@joaosaffran
joaosaffran added this pull request to stack #1592 October 14, 2026 00:43
@joaosaffran
joaosaffran marked this pull request as ready for review October 14, 2026 00:44
@llvm-beanz

Copy link
Copy Markdown
Contributor

Yes, this seems right from a correctness perspective, but if you're seeing this on the lavapipe builder, that means you didn't check out the golden images. Have you corrected that?

#--- end

REQUIRES: MeshShader
REQUIRES: MeshShader, goldenimage

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel unsure if this is the right change. To me it feels like now for lavapipe we just won't run these tests because goldenimage is not available. Maybe that is fine for local testing, but this to me seems like a strong indicator that the lavapipe ci is not setup correctly to checkout golden images. It is not clear to me why this would be a lavapipe specific failure other than for that reason.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farzonl @llvm-beanz I've updated the runners to contain goldenimages, now those tests should run. I am also removing the unsupported, since that seems to have fixed the issue, at least on my local tests, running the CI to see if the fix got applied in the runners as well.

@joaosaffran
joaosaffran marked this pull request as draft October 14, 2026 20:23
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from cccc14c to 8654118 Compare October 14, 2026 20:25
@joaosaffran
joaosaffran marked this pull request as ready for review October 14, 2026 20:42
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 0f95bba to 8654118 Compare October 15, 2026 00:20
@joaosaffran

Copy link
Copy Markdown
Contributor Author

The tests continue to fail on AMD due to issue #1552, even after adding golden images

@joaosaffran

Copy link
Copy Markdown
Contributor Author

@llvm-beanz I've checked the builders; they correctly clone golden images. I found this issue running locally, where I actually forgot to clone golden images.

@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 8654118 to 9fec5a7 Compare October 15, 2026 23:20
@joaosaffran
joaosaffran marked this pull request as draft October 17, 2026 01:06
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch 2 times, most recently from a33fa23 to e134722 Compare October 19, 2026 17:16
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from aa0cdf1 to 7d57ee9 Compare October 20, 2026 00:09
@joaosaffran
joaosaffran removed this pull request from stack #1592 October 20, 2026 00:09
@joaosaffran
joaosaffran added this pull request to stack #1614 October 20, 2026 00:11
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch 2 times, most recently from 2badb37 to 4f27674 Compare October 20, 2026 00:48
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch 4 times, most recently from 81a80eb to 49df54d Compare October 22, 2026 20:39
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 49df54d to a853665 Compare October 22, 2026 20:42
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch 4 times, most recently from 1bd0cae to 504ae44 Compare October 27, 2026 00:35
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 504ae44 to 08204c5 Compare October 28, 2026 19:44
@joaosaffran
joaosaffran removed this pull request from stack #1614 October 28, 2026 19:45
@joaosaffran
joaosaffran added this pull request to stack #1653 October 28, 2026 19:48
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 08204c5 to 76afba8 Compare October 28, 2026 21:28
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch 2 times, most recently from 3b72cb9 to 371fbdb Compare October 28, 2026 23:29
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 643c3c11-3596-47b0-acc4-1fa90c8e4d85
@joaosaffran
joaosaffran force-pushed the users/joaosaffran/meshshader-goldenimage branch from 371fbdb to afb3bad Compare October 28, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-lavapipe Run lavapipe tests, only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] MeshShaders tests use %goldenimage_dir without REQUIRES: goldenimage

4 participants