Repository navigation
Require goldenimage for mesh shader tests - #1584
joaosaffran wants to merge 1 commit into
Conversation
8d82438 to
a1cdc03
Compare
a1cdc03 to
9ef728c
Compare
|
Yes, this seems right from a correctness perspective, but if you're seeing this on the lavapipe builder, that means you didn't check out the golden images. Have you corrected that? |
| #--- end | ||
|
|
||
| REQUIRES: MeshShader | ||
| REQUIRES: MeshShader, goldenimage |
There was a problem hiding this comment.
I feel unsure if this is the right change. To me it feels like now for lavapipe we just won't run these tests because goldenimage is not available. Maybe that is fine for local testing, but this to me seems like a strong indicator that the lavapipe ci is not setup correctly to checkout golden images. It is not clear to me why this would be a lavapipe specific failure other than for that reason.
There was a problem hiding this comment.
@farzonl @llvm-beanz I've updated the runners to contain goldenimages, now those tests should run. I am also removing the unsupported, since that seems to have fixed the issue, at least on my local tests, running the CI to see if the fix got applied in the runners as well.
cccc14c to
8654118
Compare
0f95bba to
8654118
Compare
|
The tests continue to fail on AMD due to issue #1552, even after adding golden images |
|
@llvm-beanz I've checked the builders; they correctly clone golden images. I found this issue running locally, where I actually forgot to clone golden images. |
8654118 to
9fec5a7
Compare
a33fa23 to
e134722
Compare
aa0cdf1 to
7d57ee9
Compare
2badb37 to
4f27674
Compare
81a80eb to
49df54d
Compare
49df54d to
a853665
Compare
1bd0cae to
504ae44
Compare
504ae44 to
08204c5
Compare
08204c5 to
76afba8
Compare
3b72cb9 to
371fbdb
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 643c3c11-3596-47b0-acc4-1fa90c8e4d85
371fbdb to
afb3bad
Compare
The mesh shader tests compare against golden images, so they must require goldenimage.
Fix: #1555