Repository navigation
Add missing expectations for the mip counts reported by GetDimensions tests - #1625
Merged
Merged
Conversation
Check the total mip count returned by the existing Texture2D and TextureCube queries without renumbering existing outputs. Document that mip-count results are independent of the queried level. Closes llvm#1579
Icohedron
changed the title
inbelic
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1579.
Add missing expectations for the mip count reported by GetDimensions (commit 49bb0ec), and then reorder the expected buffer to match the new order in which outputs are written (commit 4f8bb1f).
This just ensures the mip-count output is the total number of mip levels in the bound view, and not something else (e.g., the number remaining below the queried mip).