Skip to content

docs: updates Terraform init example - #872

Open
ksatirli wants to merge 2 commits into
localstack:mainfrom
ksatirli:patch-1
Open

docs: updates Terraform init example#872
ksatirli wants to merge 2 commits into
localstack:mainfrom
ksatirli:patch-1

Conversation

@ksatirli

Copy link
Copy Markdown

Hey @localstack-bot!

Figured I'd update the TF example to make it work with 5.x of the azurerm provider :)

Copilot AI lite review requested due to automatic review settings August 17, 2026 17:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure Terraform integration guide to reflect newer Terraform provider requirements, aiming to keep the example working with azurerm provider 5.x.

Changes:

  • Bumps the azurerm provider version used in the example configuration.
  • Adds an explicit random provider requirement for the random_uuid resource.
  • Reorders/standardizes the azurerm provider configuration fields (including metadata_host).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 28 to +31
azurerm = {
source = "hashicorp/azurerm"
version = "=4.14.0"
version = "5.1.0"
}
Comment thread src/content/docs/azure/integrations/terraform.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@quetzalliwrites

Copy link
Copy Markdown
Collaborator

Hello @ksatirli, thank you for your contribution! :)

I'll make sure the team takes a look.

@quetzalliwrites
quetzalliwrites requested a review from a team August 18, 2026 15:52
@quetzalliwrites quetzalliwrites changed the title updates Terraform init example docs: updates Terraform init example Aug 18, 2026
@quetzalliwrites

Copy link
Copy Markdown
Collaborator

Hola @localstack/smurf @lazarkanelov, adding your folks for ENG review, this is a community contribution we just received this week.

@DrisDary DrisDary self-assigned this Aug 18, 2026
@DrisDary

Copy link
Copy Markdown
Contributor

Hi @ksatirli, thanks a lot for the contribution! 🙌

I verified your updated example end-to-end against the latest emulator build (localstack/localstack-azure:latest): terraform init resolves azurerm 5.1.0 + random 3.9.0 cleanly, apply creates the resource group as expected, and destroy works too. The bump makes sense.

That said, we still need make sure the emulator's test suites and all sample apps are bumped to 5.1.0 so the docs don't run ahead of what we validate in CI. We'll keep this PR open and merge it as part of that upgrade.

One tiny nit in the meantime: the two version constraints use different styles ("5.1.0" vs "= 3.9.0") — mind aligning them (e.g. both as "5.1.0" / "3.9.0")?

Thanks again — this kind of contribution is much appreciated! 🚀

@DrisDary DrisDary added the azure label Aug 18, 2026
@ksatirli

Copy link
Copy Markdown
Author

Hey @DrisDary!

Thanks - always happy to contribute. I think the version string was an oversight, I normally write it as `version = "> 5.1.0, < 6.0.0" but saw the @copilot request for a change.

Do you have a preference for single version or a range that allows all 5.x (but excludes 6.x)?

@DrisDary

Copy link
Copy Markdown
Contributor

Hey @DrisDary!

Thanks - always happy to contribute. I think the version string was an oversight, I normally write it as `version = "> 5.1.0, < 6.0.0" but saw the @copilot request for a change.

Do you have a preference for single version or a range that allows all 5.x (but excludes 6.x)?

Hey @ksatirli, good question!

We have a strong preference for an exact pin here. The reason is emulator-specific: we validate the LocalStack Azure emulator against a specific provider version, and azurerm minor releases regularly change wire-level behavior in ways that matter to an emulator even when they're invisible against real Azure.

With a range like >= 5.1.0, < 6.0.0, the docs example can break overnight when HashiCorp releases 5.2 — and the reader can't tell whether they broke something or we did. With an exact pin, the example always reflects a combination we've actually tested, and we bump it deliberately.

So: exact pin on both blocks please, in the repo's usual style —

version = "=5.1.0"

version = "=3.9.0"
Thanks again for kicking this off — it surfaced real work on our side that we're glad to have done! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants