fix(ios): dismiss a sheet that is unmounted while still presented - #859
Closed
SamuelBrucksch wants to merge 2 commits into
Closed
SamuelBrucksch wants to merge 2 commits into
SamuelBrucksch wants to merge 2 commits into
Conversation
|
@SamuelBrucksch is attempting to deploy a commit to the lodev09 Team on Vercel. A member of the Team first needs to authorize it. |
SamuelBrucksch
marked this pull request as ready for review
September 19, 2026 05:09
Owner
|
This is breaking with react-navigation screens + undimmed sheets. When you dismiss a screen with a presented sheet, ios waits for the sheet animation to finish before the screen dismisses causing bad UX. You can compare behavior in the example app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS, a
TrueSheetthat is unmounted while still presented stays on screen: fully drawn, dead to touches, and gone from the accessibility tree, until the user swipes it away. Only a mid-dismissal controller was handled inprepareForRecycle; a presented one was left alone.deallocwould dismiss it, but Fabric pools the host view, sodeallocnever runs in practice. Android already dismisses inonDropInstance.This dismisses the controller in
prepareForRecyclewhen it is still presented (nil-ing the delegate first, so no events reach the unmounted JS side), and lets the existing mid-dismissal block take it from there.Minimal repro on
main:Before: the sheet remains after "Unmount"; nothing behind it can be tapped. After: it animates out like a
dismiss().Type of Change
Test Plan
emitDidDismissEventsstill runs inviewDidDisappear, so_isPresentedresets and the parent's focus callbacks fire).dismiss(), swipe-to-dismiss, dim tap, and unmounting mid-dismissal (the existingisBeingDismissedpath) behave as before; noTrueSheet:warnings in the system log.Screenshots / Videos
n/a
Checklist