Repository navigation
feat(vcluster-release): check release.yaml before tagging, through release-lib - #321
Merged
sydorovdmytro merged 3 commits intoOct 16, 2026
Merged
Conversation
…elease-lib vcluster-release now sources release-lib for its routing helpers instead of carrying copies, and runs platform-release's dispatch preflight before any tag. The preflight moves into release-lib so both dispatchers share it, and it forwards source_branch to lines that declare it. A resumed tag has to be on the branch the cut routes to, and a rejected dispatch says the tag is left for a re-run to resume. The preflight needs mikefarah yq on the runner, so this ships as vcluster-release/v2.
loft-bot
reviewed
Oct 16, 2026
loft-bot
left a comment
There was a problem hiding this comment.
Panel review: 1 blocking, 3 quality notes, 11 lanes.
Blocking concerns
.github/actions/vcluster-release/test/vcluster-release.bats:2653: no legacy test checks thatsource_branchis left out whenrelease.yamldoesn't declare it. Makingcut_legacyalways forward it leaves the whole suite green.
What was checked
Checked: correctness, security, test-quality, operability, reuse, architecture, dead code, typos, coverage gaps (against DEVOPS-1364 / DEVOPS-1598 acceptance criteria), PR metadata. Skipped: e2e, infra, entry-point fidelity, layout (no e2e or infra files, no customer bug, not a restructure).
Quality notes (non-blocking)
- consider:
.github/actions/vcluster-release/test/vcluster-release.bats:2674. Could we add a legacy case where OSS is already dispatched and only the pro dispatch fails? Today only the OSS failure is exercised. This becomes blocking if the pro dispatch's failure message stops namingloft-sh/vcluster-proand the tag left behind. - consider:
.github/actions/vcluster-release/src/vcluster-release.sh:966. Couldrequire_dispatchablehand back the input list it checked, so the four call sites stop rebuilding-fargs from globals? This becomes blocking if a caller's rebuilt list drifts from the checked one and a dispatch fails after tagging. - consider:
.github/actions/vcluster-release/test/vcluster-release.bats:145. The stub answers the new tag and compare reads with pre-built values, so the real--jqfilters inresolve_tag/require_tag_on_targetnever run. This becomes blocking if one of those filters is edited.
Also covers a failed pro dispatch after OSS was dispatched.
Contributor
Author
|
On the non-blocking notes:
|
The only caller runs on GitHub-hosted Ubuntu, which ships mikefarah yq.
vcauesantos
approved these changes
Oct 16, 2026
sydorovdmytro
deleted the
devops-1364/vcluster-release-use-release-lib
branch
October 16, 2026 19:15
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_dispatchable+require_workflow_active, now in release-lib) before any tag, on every path. Legacy lines check both repos before OSS is tagged, and pro again at the head the dependency bump leaves.source_branchis forwarded to lines whoserelease.yamldeclares it, for the notifier'sbase_branch. A resumed tag must be on the branch the cut routes to (require_tag_on_target), and a rejected dispatch says the tag is left for a re-run.source-branchis trimmed and validated as a branch name, as in platform-release. Versions follow the lib's stricter grammar.yqon the runner. The only caller, vcluster-pro'scut-release.yaml, runs on GitHub-hosted Ubuntu, which ships it, so this advancesvcluster-release/v1after merge. Every live line (vcluster-promain,v0.37,v0.34–v0.36; vclusterv0.34–v0.36) passes the preflight as-is.References DEVOPS-1364
References DEVOPS-1598
Test plan
make test-vcluster-releasewith mikefarah yq v4.47.1: 236/236make test-platform-release: 335/335make test-release-lib: 39/39shellcheck -xon the three scripts,make lint(actionlint + zizmor),make generate-docswith no driftrequire_dispatchablerun against the liverelease.yamlon each line listed above