Repository navigation
Update ca-certs-nss to 3.131.1 - #113
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal currently pins ca-certs-nss 3.126. Update all six dependency declarations to the latest published stable release, 3.131.1: dune-project, the Journal and sync opam manifests, and the three affected lock files. CI's fixed opam repository snapshot is also advanced to the official commit introducing this release,
922f67e068446a8d8e809a40251a259bd0549552, so the locked version is available during CI dependency installation. Other dependency versions and TLS verification policies are unchanged.The official release and opam metadata agree on archive SHA256
86a506cff98dc63ebec4b0ee40f60347f2829f37af56ae24f49b1bcb83c3a020. The extracted set changes from 170 to 167 roots, removing emSign ECC Root CA - G3, emSign ECC Root CA - C3, and emSign Root CA - C1; no roots are added.Validation
Tested on main
e88f2c9700ed9454a65bd21c18f5fb3fc166b76ewith these six version changes:Remaining security exposure
This dependency update does not fully resolve the eMudhra incident. The package still includes AAA Certificate Services: NSS marks it as trusted for email, while its server-auth status is MUST_VERIFY_TRUST. The package's generic extraction includes it, and Journal uses the resulting collection for TLS without preserving those purpose restrictions or supplying CRLs.
All six public compromised cross-signed TLS CA certificates from the Mozilla incident attachment still establish CA paths under the new collection using offline
openssl verify -purpose any; the six expected CA-path rejection checks therefore fail. This establishes remaining CA paths, not a forged-leaf attack or a complete production TLS handshake reproduction. No private keys were recovered, and no user tokens, graphs, or attack sites were used.No SPKI denylist or other trust-policy change is included. Verification covers native sync linkage and tests; no iOS app or TestFlight build was produced.