Update vanilla js counter - #139
Open
alex-christiansen wants to merge 2 commits into
Open
alex-christiansen wants to merge 2 commits into
alex-christiansen wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…in HTML and adding an eventlistener to handle counter. The onclick within the HTML was causing a CSP violation and wasn't working.
alex-christiansen
force-pushed
the
update-vanillaJS-counter
branch
from
January 20, 2025 18:32
c6badf6 to
b7a7aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vanilla JS extension was not working because the inline event handler for the button counter was violating the CSP set by Looker. I updated the HTML, removing the inline event handler, added an ID to the button, and added an event handler outside of the HTML. I also added a missing package