Skip to content

test(chat): align operation fixture and recovery smoke - #5418

Open
LIHUA919 wants to merge 5 commits into
loopx-project:mainfrom
LIHUA919:codex/personal-workspace-elapsed-smoke
Open

LIHUA919 wants to merge 5 commits into
loopx-project:mainfrom
LIHUA919:codex/personal-workspace-elapsed-smoke

Conversation

@LIHUA919

@LIHUA919 LIHUA919 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Goal and gap

The standalone operation fixture emits prepared and delivered before confirmed, while its Python assertion expected only four later stages. In exact-head CI, the Personal Workspace browser smoke also timed out waiting for a recovered Todo card. That scenario armed its transient preview failure after reopening Goal Chat, allowing recovery to race the injection; its 5-second card deadline was tight for the history retry's 3-second backoff under CI load.

Change

  • Assert the complete six-stage operation fixture lifecycle.
  • Arm the transient preview failure before reloading, verify it was exercised, and give recovery up to 15 seconds to display the card after retry.
  • Preserve the existing product UI, persisted state and authority behavior. Signed merge d701822be integrates current main 850268bff; the contribution diff is limited to the two test files.

Validation

  • tests/test_chat_operation_actions.py: 41 passed on the integrated source.
  • Chat bundle build and verification passed.
  • Focused chat-todo-proposal real browser scenario passed in development with coverage and in the packaged Chat build.
  • The complete development browser suite was attempted: 16 scenarios passed, then team-evidence timed out waiting for its active-mode label; that scenario passed when run alone. This separate load-sensitive failure remains unclassified, so the complete suite is not claimed green.
  • node --check and git diff --check passed. Exact-head remote CI passed the four Python shards and dashboard acceptance, but aggregate pytest failed while reporting coverage for a disposable semantic-probe fixture (No source for code). #5440 owns that narrow repair. CI is red; maintainer review and merge remain pending.

中文

独立操作夹具会先输出 prepared、delivered,原 Python 断言却只接受后四个阶段。上一精确版本 CI 还在恢复后的 Todo 卡片可见性检查处超时:浏览器场景直到重新打开 Goal Chat 才启用一次性预览失败,可能与恢复完成竞争;在 CI 负载下,5 秒等待也不足以覆盖历史重试的 3 秒退避。

本 PR 校正六阶段断言,并在重载前启用预览失败,确认故障确实被触发,给恢复重试后的卡片最多 15 秒显示。产品界面、持久化和权限行为未修改。签署合并 d701822be 纳入最新 main 850268bff,相对主干仅改动两个测试文件。

整合源码上的 Python 文件测试 41 项通过;Chat 打包构建与校验通过;chat-todo-proposal 在带覆盖率的开发浏览器和打包浏览器均通过。完整开发浏览器套件曾运行,前 16 个场景通过,随后 team-evidence 等待运行状态标签超时;该场景单独运行通过,因此不能宣称完整套件已通过。语法和差异检查通过。精确版本远端 CI 的四个 Python 分片与 dashboard acceptance 已通过,但覆盖率汇总读取已清理的语义探针临时源码时失败(No source for code);独立的 #5440 负责该修复。CI 仍为红色,维护者评审与合并待完成。

Signed-off-by: Lihua <1017343802@qq.com>
@LIHUA919
LIHUA919 requested a review from huangruiteng as a code owner October 1, 2026 13:36
Signed-off-by: Lihua <1017343802@qq.com>
@LIHUA919 LIHUA919 changed the title test(workspace): make elapsed view-switch smoke deterministic test(workspace): stabilize packaged browser and fixture smokes Oct 1, 2026
Signed-off-by: Lihua <1017343802@qq.com>
Signed-off-by: Lihua <1017343802@qq.com>
Signed-off-by: Lihua <1017343802@qq.com>
@LIHUA919 LIHUA919 changed the title test(chat): align isolated operation fixture stages test(chat): align operation fixture and recovery smoke Oct 2, 2026
@Duang777

Duang777 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Exact-head CI attribution for d701822beb6892cdf7d9062b24bcc5ccc6779730 on current main@850268bffc6f7123e88f578d3743f8f6da5c5c73:

  • Run 36958279407 passed all four Python shards, Windows PowerShell, Dashboard acceptance, every TypeScript job, and all other direct checks.
  • The only direct failure was the pytest coverage aggregate. Coverage combined all four shard files, then stopped on No source for code: /tmp/.../test_cli_inspects_disjoint_ind0/loopx/a.py.
  • test(ci): isolate semantic probe fixture coverage #5375 fixes that inherited coverage leak by removing the outer pytest-cov environment from the synthetic subprocess. Its earlier exact-head run 36825867638 passed every job.
  • Current-main run 36914904063 independently fails the stale four-stage operation-fixture assertion that this PR updates. The same main run also hit the unrelated Windows process-cleanup WinError 5 seen intermittently on other branches.

The clean order is to review and merge #5418 first, then sync #5375 so its coverage fix runs with the six-stage assertion. #5409 and #5389 can sync after those baseline fixes land. No merge action was taken.

@Duang777

Duang777 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

CI triage on d701822beb6892cdf7d9062b24bcc5ccc6779730:

  • All four Python test shards, Windows, TypeScript, Stage 2C, and static checks passed.
  • The pytest aggregate failed only while combining coverage: No source for code: .../test_cli_inspects_disjoint_ind0/loopx/a.py.
  • merge-gate then failed only because the aggregate pytest job was red.
  • test(ci): isolate semantic probe fixture coverage #5375 removes pytest-cov/COVERAGE subprocess variables from this synthetic checkout. I reproduced the coverage-enabled semantic probe suite locally without the missing-source error.

There is a temporary CI dependency cycle: this PR fixes the stale operation-fixture assertion blocking #5375, while #5375 fixes this PR’s coverage aggregation failure. No changes were made to this PR branch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants