Conversation
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
This was referenced Oct 2, 2026
…atch-runtime-paths Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
Collaborator
Author
|
Exact-head update for
Fresh exact-head CI is queued. @huangruiteng please review when available. No merge action was taken. |
…atch-runtime-paths Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
4 tasks done
…atch-runtime-paths Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry_pathandruntime_root_overridearguments added by fix(upgrade): preserve configured state routes and avoid observation-only conflicts #5457Failure evidence
After #5457 reached
main,tests/test_cli_entrypoint.py::test_doctor_dispatch_preserves_owner_flags_and_failurefailed in all four parameterized cases because the mock received the two new arguments while the expected kwargs still described the old contract. The same baseline failure appeared on #5380, #5389, and #5409.Validation
tests/test_cli_entrypoint.py: 32 passedgit diff --check: passedMaintainer review and merge are required.
Signed-off-by: duanjialing.777 duanjialing.777@bytedance.com