Skip to content

test(cli): align doctor dispatch runtime paths - #5463

Open
Duang777 wants to merge 6 commits into
mainfrom
codex/fix-doctor-dispatch-runtime-paths
Open

Duang777 wants to merge 6 commits into
mainfrom
codex/fix-doctor-dispatch-runtime-paths

Conversation

@Duang777

@Duang777 Duang777 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Failure evidence

After #5457 reached main, tests/test_cli_entrypoint.py::test_doctor_dispatch_preserves_owner_flags_and_failure failed in all four parameterized cases because the mock received the two new arguments while the expected kwargs still described the old contract. The same baseline failure appeared on #5380, #5389, and #5409.

Validation

  • tests/test_cli_entrypoint.py: 32 passed
  • Ruff: passed
  • git diff --check: passed

Maintainer review and merge are required.

Signed-off-by: duanjialing.777 duanjialing.777@bytedance.com

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Duang777 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Exact-head update for 180db2e2db0aeb1144bc5525cb7b85f013dd5215 on main@2fca4a97fab7022cef6d98c4240a032a39dfee20:

  • Synced through a signed-off merge commit without rewriting history. Main now includes merged feat(telemetry): qualify installation usage and runtime clocks #5477.
  • tests/test_cli_entrypoint.py plus tests/test_windows_install.py passed: 35 tests passed and 4 platform skips. Ruff and git diff --check passed.
  • The PR diff remains limited to the doctor-dispatch fixture assertion.

Fresh exact-head CI is queued. @huangruiteng please review when available. No merge action was taken.

…atch-runtime-paths

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…atch-runtime-paths

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant