Skip to content

CI check: fs event access test (fork only) - #1

Closed
lowlyleon wants to merge 2 commits into
v1.xfrom
win-fs-event-ignore-access
Closed

lowlyleon wants to merge 2 commits into
v1.xfrom
win-fs-event-ignore-access

Conversation

@lowlyleon

Copy link
Copy Markdown
Owner

Fork-internal CI run, not for upstream.

@lowlyleon
lowlyleon force-pushed the win-fs-event-ignore-access branch from 3076122 to 7223444 Compare November 19, 2026 20:45
lowlyleon and others added 2 commits November 19, 2026 22:39
ReadDirectoryChangesW was asked for FILE_NOTIFY_CHANGE_LAST_ACCESS, so
reading a file could report UV_CHANGE. NTFS only writes the access time
back once the stored one is more than an hour old, which makes these
events look random. No other platform watches for reads (IN_ACCESS,
NOTE_READ, FILE_ACCESS), so stop asking for it on Windows too.

Fixes: libuv#5449
Refs: libuv#3083
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub's Windows runners have last access updates disabled, so
fs_event_watch_dir_ignore_access skips there. Turn them on before the
tests run. The setting takes effect without a reboot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lowlyleon
lowlyleon force-pushed the win-fs-event-ignore-access branch from 7223444 to 0e95e39 Compare November 19, 2026 21:39
@lowlyleon

Copy link
Copy Markdown
Owner Author

CI check done, upstream PR follows.

@lowlyleon lowlyleon closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant