Repository navigation
Conversation
lowlyleon
force-pushed
the
win-fs-event-ignore-access
branch
from
November 19, 2026 20:45
3076122 to
7223444
Compare
ReadDirectoryChangesW was asked for FILE_NOTIFY_CHANGE_LAST_ACCESS, so reading a file could report UV_CHANGE. NTFS only writes the access time back once the stored one is more than an hour old, which makes these events look random. No other platform watches for reads (IN_ACCESS, NOTE_READ, FILE_ACCESS), so stop asking for it on Windows too. Fixes: libuv#5449 Refs: libuv#3083 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub's Windows runners have last access updates disabled, so fs_event_watch_dir_ignore_access skips there. Turn them on before the tests run. The setting takes effect without a reboot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lowlyleon
force-pushed
the
win-fs-event-ignore-access
branch
from
November 19, 2026 21:39
7223444 to
0e95e39
Compare
Owner
Author
|
CI check done, upstream PR follows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal CI run, not for upstream.