Repository navigation
feat: UI optimizations #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,5 @@ | ||
| // src/pages/background/config.ts | ||
|
|
||
| export interface APIConfig { | ||
| baseURL: string; | ||
| apiKey: string; | ||
| model: string; | ||
| maxTokens: number; | ||
| temperature: number; | ||
| systemPrompt: string; | ||
| debug?: boolean; | ||
| } | ||
|
|
||
| export const apiConfig: APIConfig = { | ||
| // ⚠️ TODO: T012 将迁移到 chrome.storage.local | ||
| baseURL: 'https://api.deepseek.com', | ||
| apiKey: 'YOUR_API_KEY_HERE', // 替换为你的 API Key | ||
| model: 'deepseek-chat', | ||
| maxTokens: 1000, | ||
| temperature: 0.7, | ||
| systemPrompt: '你是一个专业的助手,请简洁地解释用户提供的内容。', | ||
| export const apiConfig = { | ||
| debug: false, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,6 +10,7 @@ export interface NoteCardOptions { | |||||||||||||||||||||
| id: string; | ||||||||||||||||||||||
| originalText: string; | ||||||||||||||||||||||
| targetElement: HTMLElement; | ||||||||||||||||||||||
| rect?: { width: number }; | ||||||||||||||||||||||
| onClose?: (id: string) => void; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
@@ -43,6 +44,12 @@ export class NoteCard { | |||||||||||||||||||||
| private render(): void { | ||||||||||||||||||||||
| if (!this.shadow) return; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| // Calculate dynamic width from rect if provided | ||||||||||||||||||||||
| const rectWidth = this.options.rect?.width; | ||||||||||||||||||||||
| const minWidth = Math.max(200, rectWidth || 0); | ||||||||||||||||||||||
| const maxWidth = Math.min(600, rectWidth || 420); | ||||||||||||||||||||||
| const cardWidth = rectWidth ? `${Math.min(Math.max(rectWidth, minWidth), maxWidth)}px` : '100%'; | ||||||||||||||||||||||
|
Comment on lines
+47
to
+51
|
||||||||||||||||||||||
| // Calculate dynamic width from rect if provided | |
| const rectWidth = this.options.rect?.width; | |
| const minWidth = Math.max(200, rectWidth || 0); | |
| const maxWidth = Math.min(600, rectWidth || 420); | |
| const cardWidth = rectWidth ? `${Math.min(Math.max(rectWidth, minWidth), maxWidth)}px` : '100%'; | |
| // Calculate dynamic width from rect if provided, clamped between 200px and 600px | |
| const rectWidth = this.options.rect?.width; | |
| const cardWidth = rectWidth | |
| ? `${Math.min(Math.max(rectWidth, 200), 600)}px` | |
| : '100%'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The width clamping math is incorrect when
rectWidthis below 200:maxWidthbecomesrectWidth, socardWidthcan end up < 200px (e.g., 100px), violating the intended 200–600px range. Consider simplifying to a single clamp likeclamp(rectWidth, 200, 600)and using that value for the width whenrectWidthis provided.