Skip to content

fix(register): exit when the /ready healthcheck server fails #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertodauria merged 3 commits into from
Oct 8, 2026
Merged

fix(register): exit when the /ready healthcheck server fails #102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddcda9f
fix(register): exit when the /ready healthcheck server fails
robertodauria Jul 23, 2026
a6db140
Merge branch 'main' into fix-register-healthcheck-exit
robertodauria Oct 8, 2026
5d92ea8
Merge branch 'main' into fix-register-healthcheck-exit
bassosimone Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/register/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,14 @@ func main() {

siteProb.Value = fmt.Sprintf("%f", probability)

// Set up health server.
// Set up health server. If it dies, exit so the supervisor restarts us:
// a silently dead /ready endpoint makes readiness checks fail forever
// while the process still looks healthy.
mux := http.NewServeMux()
mux.HandleFunc("/ready", Ready)
go http.ListenAndServe(*hcAddr, mux)
go func() {
rtx.Must(http.ListenAndServe(*hcAddr, mux), "Failed to serve /ready endpoint")
Comment thread
bassosimone marked this conversation as resolved.
}()

// Register for the first time.
register()
Expand Down
Loading