Skip to content

ci: run the release jobs in a release environment - #80

Merged
thomson-t merged 1 commit into
mainfrom
ci/run-the-release-jobs-in-a-release-environment
Nov 17, 2026
Merged

thomson-t merged 1 commit into
mainfrom
ci/run-the-release-jobs-in-a-release-environment

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch is main.
  2. The PR title follows the conventional-commit format the title check expects.
  3. The branch name is set when this change is published.

Summary

  • The release workflow's semantic-release and sonatype-release jobs now run in the release environment, which allows only main, so their signing and publishing credentials can live there instead of in repository- or organization-level secrets.
  • A secret not yet set in the environment still resolves from the repository or organization, so nothing breaks while the credentials move.
  • Related: the same change in ci: scope release credentials to release environments ROKT/rokt-sdk-react-native#336. No changelog entry, because nothing in the published package changes.

Testing Plan

  • The changed workflow passes actionlint, and the environment's branch rule was read back through the GitHub API.
  • After merging, run the Release workflow from main with dryRun: true: semantic-release runs in the environment without publishing.
  • The Sonatype job runs only when dryRun is false, so the next real release confirms the Sonatype credentials in the environment.

@nickolas-dimitrakas
nickolas-dimitrakas marked this pull request as ready for review November 17, 2026 18:07
@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Nov 17, 2026

@thomson-t thomson-t left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding release environment for workflow

@thomson-t
thomson-t merged commit 7111994 into main Nov 17, 2026
3 checks passed
@thomson-t
thomson-t deleted the ci/run-the-release-jobs-in-a-release-environment branch November 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants