Skip to content

ci: run the release and issue-assignment jobs in a release environment - #316

Merged
nickolas-dimitrakas merged 1 commit into
mainfrom
ci/run-the-release-and-issue-assignment-jobs-in-a
Nov 17, 2026
Merged

nickolas-dimitrakas merged 1 commit into
mainfrom
ci/run-the-release-and-issue-assignment-jobs-in-a

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Why

Release automation should hold release credentials only where releases run. The release and issue-assignment jobs read the release bot token from repository-level secrets, which every workflow on every branch can read.

Programme

Standalone change, no programme.

What changes

  • The release jobs and the issue auto-assignment job run in the release environment, which allows only main.
  • A secret not yet set in the environment still resolves from the repository or organization, so promoting this before the secrets move breaks nothing.

No changelog entry, because nothing in the published package changes.

Linked work

Related: the same change in ROKT/rokt-sdk-react-native#336.

Rollout

Path: CI only; nothing is published.

  1. Before merging: the release environment allows only main, with the token moving into it.
  2. Merge; the next release confirms it.
  3. Remove the repository-level copy.

Feature flags: none.
Turning it off: revert this pull request.
What we watch: the next release and issue assignment succeed.

Risks

  • A credential added to the environment with a wrong value overrides the repository copy; the next run fails at the step that uses it; the value is fixed or removed from the environment.

Risk class: low.

Who

Written by: an automated coding agent (Claude Code), at an engineer's request.
Code reviewed before opening: an independent review agent; no person yet.
Checked: the changed workflows pass actionlint, and the environment's rule was read back through the GitHub API.
Not checked: a run on a real runner, which the next run after merging covers.

Size

Hand-written: 2 files, 4 lines added.
Generated: none.

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Nov 17, 2026
@nickolas-dimitrakas
nickolas-dimitrakas marked this pull request as ready for review November 17, 2026 15:59
@nickolas-dimitrakas
nickolas-dimitrakas requested a review from a team as a code owner November 17, 2026 15:59
@nickolas-dimitrakas
nickolas-dimitrakas merged commit 97a48b1 into main Nov 17, 2026
17 checks passed
@nickolas-dimitrakas
nickolas-dimitrakas deleted the ci/run-the-release-and-issue-assignment-jobs-in-a branch November 17, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants