Repository navigation
ci: run the release jobs in a release environment - #1226
Conversation
🐦 Swift Migration ProgressProduction implementation code at
Objective-C retained by design: Core SDK 7,126 · SDK kit infrastructure 2,585 · Standalone kits 0. This PR's code movement
How this is measured
Generated with |
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
mParticle Core + Rokt kitThe SDK and the Rokt kit built from source by SwiftPM and linked statically, as a
➡️ SDK size impact change is minimal. Where the bytes are
Debug symbols (not shipped to users)The SDK is embedded as a dynamic framework, so the app's own executable barely
Raw measurementsTarget branch (main): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":2856,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":2772,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6420,"framework_size_kb":3020,"dsym_size_kb":3396,"core_source_app_size_kb":2456,"kit_app_size_kb":8276,"kit_executable_size_bytes":8439856,"kit_impact_kb":8192,"kit_over_core_kb":5820}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":2872,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":2788,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6436,"framework_size_kb":3036,"dsym_size_kb":3396,"core_source_app_size_kb":2456,"kit_app_size_kb":8276,"kit_executable_size_bytes":8439856,"kit_impact_kb":8192,"kit_over_core_kb":5820} |
thomson-t
left a comment
There was a problem hiding this comment.
Changing the publish environment
Why
Release automation should hold release credentials only where releases run. Release jobs read their signing, publishing and GitHub App credentials from repository- and organization-level secrets, which every workflow on every branch can read.
Programme
Standalone change, no programme.
What changes
releaseenvironment, which allows onlymain.No changelog entry, because nothing in the published package changes.
Linked work
Related: the same change in ROKT/rokt-sdk-react-native#336.
Rollout
Path: CI only; nothing is published.
releaseenvironment allows onlymainand holds the credentials.dry_runfrommain; it covers signing and the GitHub App. The next release covers the CocoaPods token.Feature flags: none.
Turning it off: revert this pull request.
What we watch: the dry run succeeds, and the next release's CocoaPods jobs push without the trunk warning.
Risks
Risk class: low.
Who
Written by: an automated coding agent (Claude Code), at an engineer's request.
Code reviewed before opening: an independent review agent; no person yet.
Checked: the changed workflows pass actionlint, and the environment's rule was read back through the GitHub API.
Not checked: a run on a real runner, which the next run after merging covers.
Size
Hand-written: 2 files, 5 lines added.
Generated: none.