Skip to content

ci: run Release Draft in a release environment - #85

Merged
thomson-t merged 1 commit into
masterfrom
ci/run-release-draft-in-a-release-environment
Nov 17, 2026
Merged

thomson-t merged 1 commit into
masterfrom
ci/run-release-draft-in-a-release-environment

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Why

Release automation should hold release credentials only where releases run. Release Draft read the release GitHub App's credentials from repository-level secrets, which every workflow on every branch can read.

Programme

Standalone change, no programme.

What changes

  • Release Draft runs in the release environment, which allows only master, and reads the release GitHub App's credentials from it. Its branch check stays as a second line.
  • README: the release steps mention the environment.

No changelog entry, because nothing in the published package changes.

Linked work

Related: the same change in ROKT/rokt-sdk-react-native#336.

Rollout

Path: CI only; nothing is published.

  1. Before merging: the release environment is created allowing only master, and the credentials are added to it.
  2. Merge; the next Release Draft confirms it.
  3. After it succeeds, remove the repository-level copies.

Feature flags: none.
Turning it off: revert this pull request.
What we watch: the next Release Draft succeeds.

Risks

  • Merged before the environment exists or holds the credentials; Release Draft fails at its token step and nothing is published; Rollout step 1 comes first.

Risk class: low.

Who

Written by: an automated coding agent (Claude Code), at an engineer's request.
Code reviewed before opening: an independent review agent; no person yet.
Checked: the changed workflow passes actionlint.
Not checked yet: the release environment, which is created before merging (Rollout step 1).
Not checked: a run on a real runner, which the next Release Draft after merging covers.

Size

Hand-written: 2 files, 3 lines added.
Generated: none.

@nickolas-dimitrakas
nickolas-dimitrakas requested a review from a team as a code owner November 17, 2026 19:34
@nickolas-dimitrakas nickolas-dimitrakas added the promoted Opened from Rokt's internal review process label Nov 17, 2026 — with Rokt Releases

@thomson-t thomson-t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the release environment to the draft workflow

@thomson-t
thomson-t merged commit dd0b051 into master Nov 17, 2026
4 checks passed
@thomson-t
thomson-t deleted the ci/run-release-draft-in-a-release-environment branch November 17, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promoted Opened from Rokt's internal review process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants