Repository navigation
ci: run the release draft in a release environment - #470
Merged
thomson-t merged 3 commits intoNov 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Access restrictions prevented verification that the pinned reusable workflow defaults to github.token when the token input is omitted, and release-environment credentials and branch restrictions still require human confirmation.
No open issues 🎉
What changed in this PR
This CI-only change scopes release credentials to the release environment and removes unused token generation from Trunk Upgrade. Published package behavior is unchanged.
Changes:
- Run Release Draft in the
releaseenvironment to use environment-scoped credentials. - Remove Trunk Upgrade’s GitHub App token job and secret requirements, retaining its existing
github.tokenfallback.
| File | Description |
|---|---|
.github/workflows/trunk-upgrade.yml |
Removes App token generation, required secrets, and token forwarding. |
.github/workflows/release-draft.yml |
Assigns the release PR creation job to the release environment. |
Review effort: Balanced
thomson-t
previously approved these changes
Nov 17, 2026
Merging main brought back Trunk Upgrade's `with: token:`, which reads an output of the token job this pull request removes. actionlint rejects the reference, and the shared workflow already falls back to `github.token`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thomson-t
approved these changes
Nov 17, 2026
thomson-t
deleted the
ci/run-the-release-draft-in-a-release-environment
branch
November 17, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release automation should hold release credentials only where releases run. Release Draft read the release GitHub App's credentials from repository-level secrets, which every workflow on every branch can read, and Trunk Upgrade's App token was already being discarded.
Programme
Standalone change, no programme.
What changes
releaseenvironment, which allowsmainandmaintenance/3.xby exact name, and reads the release GitHub App's credentials from it.github.token.No changelog entry, because nothing in the published package changes.
Linked work
Related: the same change in ROKT/rokt-sdk-react-native#336.
Rollout
Path: CI only; nothing is published.
releaseenvironment allowsmainandmaintenance/3.xand holds the credentials.maintenance/3.xgets the same change, remove the repository-level copies.Feature flags: none.
Turning it off: revert this pull request.
What we watch: the next draft release succeeds.
Risks
Risk class: low.
Who
Written by: an automated coding agent (Claude Code), at an engineer's request.
Code reviewed before opening: an independent review agent; no person yet.
Checked: the changed workflows pass actionlint, and the environment's branch policy was read back through the GitHub API.
Not checked: a run on a real runner, which the next run after merging covers.
Size
Hand-written: 2 files, 1 line added and 25 removed.
Generated: none.