You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Java SDK only had e-commerce models for automation triggers, so it couldn't reach shops, orders, variants or the revenue reports from the API - Ecommerce & Revenue project.
Changes
New ml.ecommerce() with shops, products, variants, categories, customers, orders, carts, cart items, imports and settings, using the SDK's retriever/builder pattern.
ecommerceReport() on campaigns, subscribers, automations and shops for revenue stats and attributed orders.
[Medium risk] The review's account says it read no sources outside the repository, so the endpoint paths and query parameter names (for example ecommerce_shop_id on automation order-activity and the /ecommerce/shops routes) are unverified against the MailerLite API and rest only on the tests' expected URLs, which the same author wrote. The earlier null-endpoint problem in orders() is fixed in the diff, so it no longer lowers the score. The change is additive SDK code with no auth, secret or …
Adds ecommerce API objects and revenue reports to the Java SDK
The change adds ml.ecommerce() with shops, products, variants, categories, customers, orders, carts, cart items, imports and settings. It also adds ecommerceReport() on campaigns, subscribers, automations and shops, all built on a shared EcommerceReportRetriever. The latest commits make orders() throw a MailerLiteException when a report has no orders endpoint, and restore the HTTP client after each test.
What's good
Tests check method, URL and JSON body for nearly every endpoint without hitting the network.
EcommerceRequest URL-encodes query parameters, so bracketed filter names are safe.
Review context · 0/5 commands
Commands run: none
Reviews (2) · Last reviewed commit: "ECO-600: Nits" · claude-sonnet-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Changes
ml.ecommerce()with shops, products, variants, categories, customers, orders, carts, cart items, imports and settings, using the SDK's retriever/builder pattern.ecommerceReport()on campaigns, subscribers, automations and shops for revenue stats and attributed orders.