Skip to content

ECO-600: Ecommerce Objects - #22

Open
segunmailerlite wants to merge 2 commits into
mainfrom
feature/eco-600-java-sdk
Open

segunmailerlite wants to merge 2 commits into
mainfrom
feature/eco-600-java-sdk

Conversation

@segunmailerlite

@segunmailerlite segunmailerlite commented Oct 28, 2026 •

Copy link
Copy Markdown

Why?

  • The Java SDK only had e-commerce models for automation triggers, so it couldn't reach shops, orders, variants or the revenue reports from the API - Ecommerce & Revenue project.

Changes

  • New ml.ecommerce() with shops, products, variants, categories, customers, orders, carts, cart items, imports and settings, using the SDK's retriever/builder pattern.
  • ecommerceReport() on campaigns, subscribers, automations and shops for revenue stats and attributed orders.

@segunmailerlite segunmailerlite self-assigned this Oct 28, 2026
@mailerlite-kritika

mailerlite-kritika Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 4/5

[Medium risk] The review's account says it read no sources outside the repository, so the endpoint paths and query parameter names (for example ecommerce_shop_id on automation order-activity and the /ecommerce/shops routes) are unverified against the MailerLite API and rest only on the tests' expected URLs, which the same author wrote. The earlier null-endpoint problem in orders() is fixed in the diff, so it no longer lowers the score. The change is additive SDK code with no auth, secret or …

Findings

Earlier findings (3 resolved)

Summary

Adds ecommerce API objects and revenue reports to the Java SDK

The change adds ml.ecommerce() with shops, products, variants, categories, customers, orders, carts, cart items, imports and settings. It also adds ecommerceReport() on campaigns, subscribers, automations and shops, all built on a shared EcommerceReportRetriever. The latest commits make orders() throw a MailerLiteException when a report has no orders endpoint, and restore the HTTP client after each test.

What's good

  • Tests check method, URL and JSON body for nearly every endpoint without hitting the network.
  • EcommerceRequest URL-encodes query parameters, so bracketed filter names are safe.
Review context · 0/5 commands
  • Commands run: none

Reviews (2) · Last reviewed commit: "ECO-600: Nits" · claude-sonnet-5-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants