Skip to content

ECO-598: Ecommerce Objects - #106

Open
segunmailerlite wants to merge 3 commits into
mainfrom
feature/eco-598-python-sdk
Open

segunmailerlite wants to merge 3 commits into
mainfrom
feature/eco-598-python-sdk

Conversation

@segunmailerlite

Copy link
Copy Markdown

Why?

  • The Python SDK had no e-commerce support, so it couldn't reach the shops, orders, variants or revenue reports added in the API - Ecommerce & Revenue project (ECO-598).

Changes

  • New client.ecommerce_* resources: shops, products, product variants, categories, customers, orders, carts, cart items, imports and tracking settings.
  • E-commerce report methods on campaigns, subscribers and automations, plus ecommerce_shops.stats().

@segunmailerlite segunmailerlite self-assigned this Oct 28, 2026
@segunmailerlite segunmailerlite changed the title Feature/eco 598 python sdk ECO-598: Ecommerce Objects Oct 28, 2026
@mailerlite-kritika

mailerlite-kritika Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 4/5

[Medium risk] The review read no sources outside the repository, so the new endpoint paths and request bodies (such as products/{id}/categories/multiple, change-status, automations monthly-totals/ecommerce and order-activity, and the shop reports/stats route) rest on the diff alone. The orders import wraps its list in {"orders": ...} while the products, categories and customers imports send bare lists, and nothing in the account confirms which shape the API expects. The risk stays medium as the last review …

Findings

Earlier findings (2 resolved)

Summary

Adds e-commerce resources and revenue report methods to the SDK

The PR adds ten client.ecommerce_* resources built on a shared EcommerceResource base for URL building and ID and query validation. It also adds e-commerce report methods on campaigns, subscribers and automations. Since the last review, email_ecommerce_stats validates email_id, and the tests cover the orders import body and the email_id type check.

What's good

  • Shared EcommerceResource helper keeps ID validation and filter handling consistent across resources
  • Table-driven parametrized tests assert method, URL, params and body for each endpoint
Review context · 0/5 commands
  • Commands run: none

Reviews (2) · Last reviewed commit: "ECO-598: Address review findings" · claude-sonnet-5-5

Comment thread mailerlite/sdk/automations.py Resolved
Comment thread tests/ecommerce_test.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants