Repository navigation
Conversation
…r to itself; add tests for resolution logic
…update as* methods to read missing keys as null; add asTrimmedString method for trimmed string conversion with default fallback; improve tests for new functionality
…or as* methods; update tests to verify behavior with null values and defaults.
Fix stale or inaccurate claims and fill gaps in README, CLAUDE.md, the coding standard and every module guide under docs/ (http, cache, time, collections, texts, logging, events, links, dependency-injection). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZyjWKt2WYxDc2vbY8Z6jV
Import DateTimeInterface as IDateTime in src/ and tests/, and extend the interface-alias convention in CLAUDE.md and the coding standard to PHP built-ins. Remove the "no abstract base classes in the public API" rule from CLAUDE.md, which no longer reflects the codebase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZyjWKt2WYxDc2vbY8Z6jV
- FileCachePool: re-check expiry of a remembered entry so an item read or saved on the same instance stops being a hit once it expires; the stale file is deleted, as for a first read. - RequestFactory::createServerRequest(): drop server params whose key is not a string, as ServerRequest::fromGlobals() does, instead of calling a check whose result was ignored and whose @phpstan-assert lied. - Iter::unique() / Seq::unique(): throw TypeError for a null element when no key selector is given, matching the documented contract (null was silently coerced to '' and is a deprecated array offset in PHP 8.5). - Mark Http\Internal\AbstractMessage as @internal. Closes #22 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZyjWKt2WYxDc2vbY8Z6jV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Fixes for #22
FileCachePoolreturned expired entries from its per-instance memo.read()now checks the expiry of a remembered entry again. An expired one becomes a miss, and its file is deleted, the same as on a first read. New test:getItem_missesOnceARememberedItemHasExpiredOnTheSameInstance.RequestFactory::createServerRequest()ignored its own key check. Server params whose key is not a string are now dropped, which is whatServerRequest::fromGlobals()already does for$_SERVER.'ignored-non-string-key', and PSR-17 declares no exception for this method.@phpstan-asserthelper is gone.Iter::unique()/Seq::unique()did not throw fornullwithout a key selector. They now throwTypeError, as the PHPDoc anddocs/collections.mdalready said.nullwas silently turned into the key''.nullas an array offset.uniqueThrowsTypeErrorForNullElementWithoutKeySelector.Http\Internal\AbstractMessagewas missing@internal. Added.docs/http.mdanddocs/collections.mdare updated for fixes 2 and 3.Also on this branch (already pushed to
dev0.0.3)DateTimeInterfaceis now imported asIDateTime. The interface-alias convention now covers PHP built-ins.dev0.0.3work:nullGet,asTrimmedString, and defaults foras*.ContainerInterfaceto itself.make()and autowiring.Testing
composercould not install dependencies in the authoring environment, so phpcs, phpstan and PHPUnit were not run locally. CI on this PR runs them.nullthrows, and the existing coercion behaviour ofunique()is unchanged.php -l.🤖 Generated with Claude Code
https://claude.ai/code/session_017ZyjWKt2WYxDc2vbY8Z6jV
Generated by Claude Code