Introduce Oxc::Node and Oxc::Visitor - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request gives
parsea way to be walked. Until now it only returned a JSON blob with no way of traversing it.A field reads by name, and comes back wrapped when it holds a node, so reads chain.
respond_to_missing?is wired to the real keys, so a field the node does not carry raisesNoMethodError.Oxc::Visitoranswers a node with the method named after its type, and walks through anything nothing answers.Dispatch snake-cases the ESTree type with acronym runs handled, so
TSTypeAnnotationanswers tovisit_ts_type_annotationandJSXElementtovisit_jsx_element.