fix: correct MSRV to 1.86, repair mojibake, drop unusable crates.io publishing - #8
Open
marcuspat wants to merge 3 commits into
Open
fix: correct MSRV to 1.86, repair mojibake, drop unusable crates.io publishing#8marcuspat wants to merge 3 commits into
marcuspat wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7, which merged while these were in flight. Three items, one of them a build break the UAT report scored as PASS.
docker buildcannot succeed todayThe builder image is
rust:1.82-slim, but the dependency graph has moved past it:rust-versionratatui 0.30clap 4.6Cargo refuses the workspace before compiling anything. Same class as the Go-version mismatch flagged in spacelift-intent as SBLD-007 — the report scored Sentinel's build/deploy section 7/7.
rust:1.86-slimrust-version = "1.86"added toworkspace.package, so cargo reports the real floor instead of failing deep inside a dependencyThe TUI printed mojibake
Box-drawing rules, em dashes, arrows and ellipses were committed as double-encoded UTF-8 — the byte sequence you get by decoding real UTF-8 as Latin-1 and re-encoding. These are output strings, not just comments:
3,096 sequences repaired across the four
sentinel-tuisources and the Dockerfile. The repair re-encodes each run to Latin-1 and decodes it as UTF-8, so every character is restored to what was originally typed rather than guessed.crates.io publishing was never going to work
sentinel-agent(the README badge)sentinel-coresentinel-tuiThe publish job added in #7 could not succeed under these names. Per your call: badge and publish job removed. Releases ship binaries and container images; the four-target build with SHA-256 sums and CHANGELOG-derived release notes is untouched. Nothing forecloses publishing later under an available name.
Verification
cargo clippy --workspace --all-targets -- -D warningsclean andcargo test --workspace413 passing against this tree. Every file was verified by git blob SHA against the locally built and tested copy.Still open
cargo fmt --all -- --checkfails across ~250 sites on current stable. CI doesn't run it and I left it out of the release workflow rather than bundle a whole-tree reformat here —cargo fmt --allon this branch is a one-command follow-up if you want it, andcargo fmt --checkcan go into CI once the tree is clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01WhYNu2HEX62gqqtcPM5twr