Repository navigation
Fix triangle fill striping and black corners on alpha-off surfaces - #338
Merged
Merged
Conversation
, #332) Moving flat triangles were filled with fanned lines that left gaps, and a coarse fill was never redrawn because SceneObjectRectangle/Polygon always reported didFastDraw: false. Small triangles now fill with DrawRect bands, coarse bands only while moving, and lossy fills are reported so they get redrawn once still. The Renderer turns on alpha blending on its target, so temp bitmaps' transparent corners no longer black out what's behind them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…band axis and grid - SceneObjectRectangle's direct canvas draw only allows the coarse fill while moving - triangles sharing an edge band the same way, on a grid aligned to the band size - document that Renderer turns on alpha blending on its target Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119, fixes #332
DrawTransformedObjectquirk - the demo draws to analphaEnable: falsebitmap, so the later walls' temp bitmaps copied their transparent corners as black over the side walls.Renderernow turns alpha blending on for its target.DrawRectbands (drawTriangleAsSpansTo). AlsoSceneObjectRectangle/Polygonalways saiddidFastDraw: false, so a coarse fill never got redrawn once still - they now checkgetLossyTriangleFillCount().triangleQuickDrawThresholdfrom the quality settings.triangle-fill-checkcompares/times each fill method.BSP benchmark on device: 1966ms vs 2177ms on main. examples/3d RectanglesScene FPS unchanged.
🤖 Generated with Claude Code