Repository navigation
Drop stale >512 tile chunk warnings (#213) - #340
Merged
Merged
Conversation
Re-tested on a Roku: chunkSize 768 and 1024 draw the platformer's floating platform fine. 512 stays the recommendation for texture memory. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #213
Turns out #258 fixed this - the vanishing chunk was being culled by its top-left corner. Re-tested level 1 on a Roku with chunkSize 768 and 1024, floating platform draws fine. Keeping 512 anyway since bigger chunks waste texture memory on the gaps, so the comments/docs now say that instead.
🤖 Generated with Claude Code