Repository navigation
fix(bump-consumers): regenerate the umbrella's wiring block in its… - #81
Merged
Merged
Conversation
…mp commit The umbrella's quality-other runs `wiring --check`, and REPOS.md's generated block lists every repo's devkit pins, so each umbrella bump PR failed as stale until someone regenerated one line by hand (marola-dev/marola#764). As the canary for auto-merge it would never go green and no code repo would follow. When the bumped repo's docs/2-Building-marola/REPOS.md carries the wiring markers, the bump now checks out its submodules at depth 1 and runs the new tag's wiring (`nix run github:marola-dev/marola-devkit/vX.Y.Z#wiring`; BUMP_WIRING overrides it) before committing, the same pattern as the umbrella's pointer-sync.sh. The tag's, not this checkout's: the block must match what the bumped repo's own gate runs. A wiring failure fails that repo's bump rather than pushing a stale block; a repo without the markers is bumped exactly as before. Closes #78 Tested: bump-consumers --self-test red (6 FAIL: no block in the commit, wiring never ran, a wiring failure still pushed) then green with umbrella_bump_regenerates_wiring_block, repo_without_markers_unchanged, wiring_failure_fails_that_repo; shellcheck (default severity) clean; actionlint; docs_lint; tests/self-tests.sh all ok Cost: ~$5.73 · diff-size estimate (cost-split --estimate-commit) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
changed the title
…andbox The fake gh and wiring were written with #!/usr/bin/env bash, which the sandbox lacks, so nix flake check's self-tests derivation failed the new umbrella case while the local run passed; #!$BASH, as graph.sh, stack.sh and ruleset-sync.sh write their fakes. Tested: bump-consumers --self-test; shellcheck; the sandbox run is devkit CI's nix flake check Cost: ~$0.30 · diff-size estimate (two shebangs) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
brunogbv
added a commit
that referenced
this pull request
Oct 10, 2026
* test(self-tests): refuse a fake script with an env shebang The flake's self-tests run in the Nix build sandbox, which has no /usr/bin/env, so a fake written with #!/usr/bin/env passes locally and fails only in CI; it broke #61 and #81 on the same day. tests/self-tests.sh now fails on any #!/usr/bin/env below a file's first line in scripts/, plugins/ and tests/, and checks itself on a red and a green fixture each run. Closes #83 Tested: tests/self-tests.sh green on main with #81's fakes; a planted #81-style fake in scripts/temps.sh fails it naming the line, removed it passes; the fixture check red/green; shellcheck (warning+); docs_lint Cost: ~$1.33 · diff-size estimate (cost-split --estimate-commit) Co-Authored-By: Claude <noreply@anthropic.com> * docs(development): fakes start with #!$BASH, and why Part of #83: the self-test section names the convention tests/self-tests.sh now enforces. Tested: docs_lint Cost: ~$0.15 · diff-size estimate (one paragraph) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary — The umbrella's quality-other runs
wiring --check, and REPOS.md's generated block lists every repo's devkit pins, so each umbrella bump PR failed as stale until someone regenerated one line by hand (marola-dev/marola#764). As the canary for auto-merge it would never go green and no code repo would follow.Closes #78
227a2f0)What changed
227a2f0)Not run for real yet (no Nix in this session): the default
nix run github:marola-dev/marola-devkit/vX.Y.Z#wiringpath (apps.wiringexists: devkit CI's flake check validates it) and the shallow submodule fetch. The named test is the next release's umbrella bump PR going green with no hand edit, as marola-dev/marola#764 needed one.