Skip to content

Give payload packets eight bytes of tail slack #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gafferongames wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Give payload packets eight bytes of tail slack #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a45e86d
Give payload packets eight bytes of tail slack
gafferongames Sep 8, 2026
ca1030d
Pin the payload tail at eight bytes for the reader contract
gafferongames Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion netcode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,9 +1487,17 @@ struct netcode_connection_payload_packet_t
{
uint8_t packet_type;
uint32_t payload_bytes;
uint8_t payload_data[1];
/* serialize's BitReader loads an 8-byte window from the current byte, so a
read in the last payload byte reaches 7 past it. This array is the last
member; sizeof(*packet)+payload_bytes is allocated, leaving 8 bytes
behind the returned payload pointer. Do not shrink it. */
uint8_t payload_data[8];
};

typedef char netcode_payload_packet_tail_holds_reader_slack[
( sizeof( struct netcode_connection_payload_packet_t )
- offsetof( struct netcode_connection_payload_packet_t, payload_data ) >= 8 ) ? 1 : -1 ];

struct netcode_connection_disconnect_packet_t
{
uint8_t packet_type;
Expand Down
Loading