Skip to content

fix(desktop): passkey requests no longer hang forever in browser tabs - #50

Merged
maschwenk merged 1 commit into
mainfrom
max/okta-1password-passkey
Nov 11, 2026
Merged

maschwenk merged 1 commit into
mainfrom
max/okta-1password-passkey

Conversation

@maschwenk

@maschwenk maschwenk commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

okta passkey sign-in with 1password never finishes in the in-app browser. you pick the passkey, okta sits on "verify with a passkey" forever, no prompt anywhere. same flow in helium is one click

turns out 1password is mostly fine here, the hang is ours:

  • 1password's MAIN-world hook does load and does catch okta's navigator.credentials.get
  • its "use passkey" banner closes itself 30s after it first shows up, and on okta it first shows up on the username page, so the clock is already running when you get to the passkey step
  • when it closes, 1password hands the request back to the browser (fallback-requested). chrome/helium answer that with the system passkey sheet. our fork build has neither the managed web-browser.public-key-credential entitlement nor touch id, and electron has no webauthn ui, so chromium just holds the request open with nothing on screen. every later webauthn call in that frame then fails with "a request is already pending"

caught it live in a T3 tab by hooking 1password's page messages: request at 23:14:24, fallback-requested at 23:14:46 with no clicks, exactly 30s after the banner first loaded. clicking "use passkey" inside the window does return get-credential-success (i blocked it from reaching okta so nothing actually signed in)

what changed: macOS builds with no system sheet and no touch id now refuse modal get/create right away, the same thing a dismissed browser sheet does. okta shows its "retry", the retry goes back through 1password, banner comes back, click, done. it reuses the existing passkey bridge preload hook (installed before extension content scripts, so 1password's saved "browser get" is ours). conditional/autofill requests and isUserVerifyingPlatformAuthenticatorAvailable etc stay native so sites dont start pushing passkeys we cant serve. builds with the entitlement or touch id are untouched

tradeoff: on those builds a usb security key can no longer answer a page directly (chromium had no ui for pin entry anyway). linux left alone

checked in electron 44 with a copy of the real 1password extension and the real preview preload: today the fallback is still pending after 8s, with this it rejects NotAllowedError as soon as 1password lets go

ran it end to end in a dev build of this branch with 1password signed in: banner spawned 23:34:00, 1password handed the request back at 23:34:30, okta showed its retry right away instead of hanging, retry brought the banner back, one click on use passkey and it landed on charon's admin page signed in. 1password's own log: HandlePasskeyClick: Successfully signed in with a passkey

related:

claude opus 5.5 in claude code did the digging and the fix

1Password's in-page passkey banner closes itself 30 seconds after it first
appears and hands the request back to the browser. Chrome answers that with
its own passkey sheet; macOS builds without the system passkey sheet or
Touch ID have nothing, so Chromium kept the request open with no UI and Okta
sat on "Verify with a passkey" for good.

Those builds now refuse modal passkey requests at once, as a dismissed sheet
would, so the page shows its retry and 1Password can take the next request.
Conditional requests and feature checks stay native.
@maschwenk maschwenk added the coder-task-generated Created from a coding task label Nov 10, 2026
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 10, 2026
@maschwenk
maschwenk marked this pull request as ready for review November 11, 2026 00:00
@maschwenk
maschwenk merged commit 46a586a into main Nov 11, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coder-task-generated Created from a coding task size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant