Repository navigation
fix(desktop): passkey requests no longer hang forever in browser tabs - #50
Merged
Merged
Conversation
1Password's in-page passkey banner closes itself 30 seconds after it first appears and hands the request back to the browser. Chrome answers that with its own passkey sheet; macOS builds without the system passkey sheet or Touch ID have nothing, so Chromium kept the request open with no UI and Okta sat on "Verify with a passkey" for good. Those builds now refuse modal passkey requests at once, as a dismissed sheet would, so the page shows its retry and 1Password can take the next request. Conditional requests and feature checks stay native.
maschwenk
marked this pull request as ready for review
November 11, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
okta passkey sign-in with 1password never finishes in the in-app browser. you pick the passkey, okta sits on "verify with a passkey" forever, no prompt anywhere. same flow in helium is one click
turns out 1password is mostly fine here, the hang is ours:
navigator.credentials.getfallback-requested). chrome/helium answer that with the system passkey sheet. our fork build has neither the managedweb-browser.public-key-credentialentitlement nor touch id, and electron has no webauthn ui, so chromium just holds the request open with nothing on screen. every later webauthn call in that frame then fails with "a request is already pending"caught it live in a T3 tab by hooking 1password's page messages: request at 23:14:24,
fallback-requestedat 23:14:46 with no clicks, exactly 30s after the banner first loaded. clicking "use passkey" inside the window does returnget-credential-success(i blocked it from reaching okta so nothing actually signed in)what changed: macOS builds with no system sheet and no touch id now refuse modal
get/createright away, the same thing a dismissed browser sheet does. okta shows its "retry", the retry goes back through 1password, banner comes back, click, done. it reuses the existing passkey bridge preload hook (installed before extension content scripts, so 1password's saved "browser get" is ours). conditional/autofill requests andisUserVerifyingPlatformAuthenticatorAvailableetc stay native so sites dont start pushing passkeys we cant serve. builds with the entitlement or touch id are untouchedtradeoff: on those builds a usb security key can no longer answer a page directly (chromium had no ui for pin entry anyway). linux left alone
checked in electron 44 with a copy of the real 1password extension and the real preview preload: today the fallback is still pending after 8s, with this it rejects
NotAllowedErroras soon as 1password lets goran it end to end in a dev build of this branch with 1password signed in: banner spawned 23:34:00, 1password handed the request back at 23:34:30, okta showed its retry right away instead of hanging, retry brought the banner back, one click on use passkey and it landed on charon's admin page signed in. 1password's own log:
HandlePasskeyClick: Successfully signed in with a passkeyrelated:
claude opus 5.5 in claude code did the digging and the fix