Conversation
Some WinRM responses, including Windows 7, omit rsp:ShellId and expose the ShellId only through the WS-Man SelectorSet. Parse either representation and add a regression test for the selector-only response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some WinRM responses, including those returned by Windows 7 SP1, do not
include
rsp:ShellIdin the shell creation response. The ShellId is insteadavailable only in the WS-Man
SelectorSet:ParseOpenShellResponsecurrently only searches for//rsp:ShellId, causingthe parsed ShellId to be empty and subsequent WinRM commands to fail.
This change allows either representation:
A regression test was added for a response containing only the selector form.
Tested with:
The new regression test fails with the original XPath and passes with this
change. The full test suite also passes with the fix.