Skip to content
This repository was archived by the owner on Mar 27, 2023. It is now read-only.

Implement API rate limits - #181

Open
Baschdl wants to merge 3 commits into
create-persistent-filtering-ecosystemfrom
177-limit_api
Open

Baschdl wants to merge 3 commits into
create-persistent-filtering-ecosystemfrom
177-limit_api

Conversation

@Baschdl

@Baschdl Baschdl commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

With this settings, a user is only allowed to retrieve 15*100=1500 users per day. @match4everyone/match4everyone Currently, this has to be changed in the settings/common.py and not like in A.py and B.py. Do we want to expose such general settings also in something like a general.py or should we just document that the user has to change that in settings/common.py?

Closes #177

Depends on #173

@feeds

feeds commented Jul 21, 2020

Copy link
Copy Markdown
Collaborator

I would raise the limit per minute. Skipping through more than 5 pages and adapting the filter several times (= one requests each) is quite normal. I would set it to 40 the least. Bigger crawlers will be stopped by the hour wise rate limit.

@feeds

feeds commented Jul 21, 2020

Copy link
Copy Markdown
Collaborator

I think its a rather technical setting, so it should go to settings.py

@Baschdl

Baschdl commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

After long negotiations, we settled for 15/min

@Baschdl

Baschdl commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@feeds Mind leaving a review? 😄

@Baschdl

Baschdl commented Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

@feeds @bjrne @maltezacharias Anyone?

@bjrne bjrne self-assigned this Sep 13, 2020
@bjrne
bjrne self-requested a review September 13, 2020 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants