This repository was archived by the owner on Mar 27, 2023. It is now read-only.
224 browser auto fill - #225
Open
maltezacharias wants to merge 7 commits into
Open
maltezacharias wants to merge 7 commits into
maltezacharias wants to merge 7 commits into
Conversation
maltezacharias
marked this pull request as ready for review
September 3, 2020 15:18
Contributor
|
Where is the password included in the mail? |
Contributor
|
The new password on |
Contributor
Author
Sorry, I meant link to reset the password.
I tested that and it updated fine here. (Tested on Windows&Chrome) with 64d4b5b |
Contributor
Author
|
@Baschdl could you answer the above? |
Contributor
Author
|
One more idea: This might not work on non-ssl pages, I tested with a local SSL Proxy and a properly signed certificate |
Contributor
|
I used Firefox on Mac OS |
Baschdl
approved these changes
Oct 6, 2020
Baschdl
left a comment
Contributor
There was a problem hiding this comment.
Saving of username+password works, auto-generation of password doesn't work in Safari, Firefox and Chrome on Mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224
Introduces a new hidden (via css) field in the password reset form with the username and appropriate autocomplete settings so that credentials will be saved in the browser.
Considered if this was bad practice but considering that our password reset mail includes the e-mail as well as the password this should be good. Additionally with this changes users will be able to use autogenerated passwords as suggested by current browsers which also benefits account security
ToDo: