Skip to content
This repository was archived by the owner on Mar 27, 2023. It is now read-only.

224 browser auto fill - #225

Open
maltezacharias wants to merge 7 commits into
stagingfrom
224-browser-auto-fill
Open

maltezacharias wants to merge 7 commits into
stagingfrom
224-browser-auto-fill

Conversation

@maltezacharias

@maltezacharias maltezacharias commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Closes #224

Introduces a new hidden (via css) field in the password reset form with the username and appropriate autocomplete settings so that credentials will be saved in the browser.

Considered if this was bad practice but considering that our password reset mail includes the e-mail as well as the password this should be good. Additionally with this changes users will be able to use autogenerated passwords as suggested by current browsers which also benefits account security

ToDo:

  • Check if same change needs to be applied to password change template

@maltezacharias
maltezacharias marked this pull request as ready for review September 3, 2020 15:18
@Baschdl

Baschdl commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Where is the password included in the mail?

{% blocktrans stripped %}
You are receiving this mail to create a new password with the following link.
{% endblocktrans %}
{% block reset_link %}
{{ protocol }}://{{ domain }}{% url 'password_reset_confirm' uidb64=uid token=token %}
{% endblock %}
{% blocktrans stripped %}
Thank you,
match4everyone
{% endblocktrans %}

@Baschdl

Baschdl commented Sep 12, 2020

Copy link
Copy Markdown
Contributor

The new password on password_change is also not properly detected

@maltezacharias

maltezacharias commented Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

Where is the password included in the mail?

Sorry, I meant link to reset the password.

The new password on password_change is also not properly detected

I tested that and it updated fine here. (Tested on Windows&Chrome) with 64d4b5b
What did you use to test?

@maltezacharias

Copy link
Copy Markdown
Contributor Author

@Baschdl could you answer the above?

@maltezacharias

Copy link
Copy Markdown
Contributor Author

One more idea: This might not work on non-ssl pages, I tested with a local SSL Proxy and a properly signed certificate

@Baschdl

Baschdl commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

I used Firefox on Mac OS

@Baschdl Baschdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving of username+password works, auto-generation of password doesn't work in Safari, Firefox and Chrome on Mac

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Make sure browser know which parts to auto-fill and password-save

2 participants