This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Conversation
bjrne
reviewed
Oct 5, 2020
bjrne
left a comment
bjrne
left a comment
Member
There was a problem hiding this comment.
Seems good, will test locally when complete. I like the separation of the apps :)
| if B.profile_visible_for_participants_of_different_type: | ||
| if settings.PARTICIPANT_SETTINGS[ | ||
| "B" | ||
| ].profile_visible_for_participants_of_different_type: |
Member
There was a problem hiding this comment.
Very ugly formatting 🙈
I know its not your fault, it just looks awful.
|
|
||
| * ``name`` - the name with which this participant group should be referred to on the website itself | ||
|
|
||
| * ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below. |
Member
There was a problem hiding this comment.
A hyperlink could be useful in the finished PR
Suggested change
| * ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below. | |
| * ``properties`` - the list of properties that the participant type should be able to set on signup. The available properties are documented below_. | |
| .. _below: :ref:`configuration:properties` |
feeds
marked this pull request as ready for review
October 7, 2020 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement of the configuration documentation (baby steps :))
Also, our app should not directly import "match4everything" for compatibility reasons, so we import the configuration from
django.confnow