rev C: honor a STARTMODE config option for power-on display - #1076
Open
jeffreyjacques wants to merge 1 commit into
Open
rev C: honor a STARTMODE config option for power-on display#1076jeffreyjacques wants to merge 1 commit into
jeffreyjacques wants to merge 1 commit into
Conversation
The revision C protocol already defines STARTMODE_DEFAULT/IMAGE/VIDEO (byte 0 of the OPTIONS payload), but SetOrientation always sent DEFAULT, which blanks the panel at power-on until the host connects. The panel keeps this setting across power cycles. Read an optional display.STARTMODE config value (DEFAULT/IMAGE/VIDEO) so a display fitted with an SD card can instead replay the last image or video it was sent. Defaults to DEFAULT, so behavior is unchanged unless the option is set; unknown values warn and fall back to DEFAULT. config.yaml is intentionally not modified (guarded by CI); maintainers can add the documented 'STARTMODE: DEFAULT' key to the shipped template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revision C protocol already defines STARTMODE_DEFAULT/IMAGE/VIDEO (byte 0 of the OPTIONS payload), but SetOrientation always sent DEFAULT, which blanks the panel at power-on until the host connects. The panel keeps this setting across power cycles.
Read an optional display.STARTMODE config value (DEFAULT/IMAGE/VIDEO) so a display fitted with an SD card can instead replay the last image or video it was sent. Defaults to DEFAULT, so behavior is unchanged unless the option is set; unknown values warn and fall back to DEFAULT.
config.yaml is intentionally not modified (guarded by CI); maintainers can add the documented 'STARTMODE: DEFAULT' key to the shipped template.