Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions numpy_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@ def max_index(X):
i = 0
j = 0

# TODO
if not isinstance(X, np.ndarray):
raise ValueError("X must be a numpy array.")
if X.ndim != 2:
raise ValueError("X must be a 2D array.")

i, j = np.unravel_index(np.argmax(X), X.shape)
i, j = int(i), int(j)

return i, j

Expand All @@ -62,6 +68,8 @@ def wallis_product(n_terms):
pi : float
The approximation of order `n_terms` of pi using the Wallis product.
"""
# XXX : The n_terms is an int that corresponds to the number of
# terms in the product. For example 10000.
return 0.
if n_terms == 0:
return 1.
k = np.arange(1, n_terms + 1)
product = np.prod(4 * k**2 / (4 * k**2 - 1))
return 2 * product
68 changes: 54 additions & 14 deletions sklearn_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,47 +28,87 @@
from sklearn.utils.multiclass import check_classification_targets


class OneNearestNeighbor(BaseEstimator, ClassifierMixin):
"OneNearestNeighbor classifier."
class OneNearestNeighbor(ClassifierMixin, BaseEstimator):
"""OneNearestNeighbor classifier.

Predict the label of each sample as the label of the closest training
sample, using the Euclidean distance.
"""

def __init__(self): # noqa: D107
pass

def fit(self, X, y):
"""Write docstring.

And describe parameters
"""Fit the classifier on the training data.

Parameters
----------
X : ndarray of shape (n_samples, n_features)
The training samples.
y : ndarray of shape (n_samples,)
The training labels.

Returns
-------
self : OneNearestNeighbor
The fitted classifier.
"""
X, y = check_X_y(X, y)
check_classification_targets(y)
self.classes_ = np.unique(y)
self.n_features_in_ = X.shape[1]

# XXX fix
self.X_train_ = X
self.y_train_ = y
return self

def predict(self, X):
"""Write docstring.
"""Predict the labels of the input samples.

Parameters
----------
X : ndarray of shape (n_samples, n_features)
The samples to classify.

And describe parameters
Returns
-------
y_pred : ndarray of shape (n_samples,)
The predicted labels.
"""
check_is_fitted(self)
X = check_array(X)
if X.shape[1] != self.n_features_in_:
raise ValueError(
f"X has {X.shape[1]} features, but OneNearestNeighbor "
f"is expecting {self.n_features_in_} features as input"
)
y_pred = np.full(
shape=len(X), fill_value=self.classes_[0],
dtype=self.classes_.dtype
)

# XXX fix
distances = np.linalg.norm(
X[:, np.newaxis, :] - self.X_train_[np.newaxis, :, :], axis=2
)
y_pred[:] = self.y_train_[np.argmin(distances, axis=1)]
return y_pred

def score(self, X, y):
"""Write docstring.

And describe parameters
"""Compute the accuracy of the classifier.

Parameters
----------
X : ndarray of shape (n_samples, n_features)
The test samples.
y : ndarray of shape (n_samples,)
The true labels.

Returns
-------
score : float
The fraction of correctly classified samples.
"""
X, y = check_X_y(X, y)
y_pred = self.predict(X)

# XXX fix
return y_pred.sum()
return np.mean(y_pred == y)
Loading