You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Line number for a binary change (without hunks) #122
I'd like to know which line of the diff the line: Binary files Binary files /t/p1/a.png and /t/p2/a.png differ is.
Since it doesn't have hunks I don't think that this is currently possible.
In PatchSet._parse there is unused_diff_line_no which likely contains it. I think that perhaps this could be added to PatchedFile and then the caller would have easy access.
Actually in other cases I get the line number of the first hunk of the file and substract 3 to get what would be the line number of the file.
Have this been discussed? I might propose an implementation if could be merged at that level (PatchedFile) but I haven't checked if this would require bigger changes everywhere.
Activity
Merge pull request #136 from matiasb/review/11-diff-line-no
matiasb commentedon Jul 18, 2026
Implemented by #136