Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: none, ad-hoc
This updates a few dependencies, notably major versions of Hackney and HTTPoison.
For Hackney, I consulted their migration guide. I believe that the only change relevant to how we use Hackney is around the pool behavior. In particular, SSL connections are now not pooled, and most of our requests from Concentrate are probably going via SSL. I'll run this on a dev environment for a while to see if there's any impact. The upgrade to 4.0 is not mentioned in that migration guide, but I looked at the relevant entry in their NEWS.md and I don't think any of the changes are pertinent to us.
For HTTPoison, I looked at a combination of the 2.x upgrade guide in the README as well as the CHANGELOG. I do not believe that any of the changes in question are relevant to how Concentrate uses HTTPoison.