feat(Schedules.Trip): parse the next trip - #3484
Merged
Merged
Conversation
thecristen
enabled auto-merge (squash)
September 9, 2026 17:23
lvachon1
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: part of Follow up on "🛜 🐞 Daily Schedules sometimes doesn't show school trips "
Implementation
/transfersendpoint api#1074Following this V3 API PR, we can now get information about in-seat transfers. In-seat transfers specifically use
transfer_type=4.More about transfers and example API response.
This PR lets us get transfers from a trip (via its
from_trip_transfersrelationship), and for in-seat transfers, get the transfer's relatedto_tripID, and save this value in%Schedules.Trip{}'s newnext_trip_idfield.Note
I did use Copilot for the third commit, which slightly refactors our parsing module. Our current code infinitely recurses when there are nested relations with repeated types (like a trip's related transfer's related trip) :(