Repository navigation
Replace Python lab tooling with a Zig labtool - #4
Conversation
The Docker labs and the capture benchmark used Python for listeners, service fakes, UDP noise and output checks. They now use: - tests/lab/labtool.zig, a static Linux helper built by `zig build lab-tools` (not part of the default install): TCP listeners, UDP echo, SSH/FTP/SMTP banners, DNS over TCP and HTTP fakes, UDP noise and a wait-for-port helper. - openssl s_server for the TLS fake. - jq and xmllint to check the JSON, JSONL and XML output. The HTTP fake now reports "zigmap-lab/1.0", and the service matcher test uses a lighttpd banner. CI cross-compiles labtool on both runners, and its parser test runs under `zig build test` on Linux. Connect lab, bridge lab and one capture-bench run (ring mode) pass on Linux aarch64.
ECC Tools / Security EvidenceCommit: Security evidence gate passed (success) No security-sensitive scanner-evidence gap detected. Mode: enforce Scanned 11 changed file(s). No missing scanner-evidence signal was detected. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
ECC Tools / PR Risk TaxonomyCommit: PR taxonomy review recommended (neutral) Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation. Scanned 11 changed file(s). Roadmap taxonomy buckets: Security EvidenceSecurity-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence. Signals:
Paths:
CI/CD RecommendationCI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work. Signals:
Paths:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Reference Set ReadinessCommit: Reference set readiness gaps detected (neutral) Reference evidence present for 0/7 areas (0%) across 11 changed file(s). This check is based on files changed in this PR. Repository-level readiness is still reported by
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / Hosted Promotion ReadinessCommit: Hosted promotion readiness passed (success) No hosted promotion evidence gaps detected across 11 changed file(s); 0 corpus scenarios had matching evidence. This check compares PR file changes against the evaluator/RAG promotion corpus in No evaluator corpus scenarios matched this PR. Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Config AuditCommit: No changed-config issues detected (success) Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules. Changed config files:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
ECC Tools / PR Harness AuditCommit: No harness issues detected (success) Scanned 1 changed config file(s) and found no harness issues. Changed config files:
Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
The Docker labs and the capture benchmark used Python for listeners,
service fakes, UDP noise and output checks. They now use:
zig build lab-tools(not part of the default install): TCP listeners,UDP echo, SSH/FTP/SMTP banners, DNS over TCP and HTTP fakes, UDP noise
and a wait-for-port helper.
The HTTP fake now reports "zigmap-lab/1.0", and the service matcher test
uses a lighttpd banner. CI cross-compiles labtool on both runners, and
its parser test runs under
zig build teston Linux.Connect lab, bridge lab and one capture-bench run (ring mode) pass on
Linux aarch64.
Note
Low Risk
Changes affect test/lab infrastructure and CI build steps only, not the scanner binary or production runtime behavior.
Overview
Replaces Python lab dependencies with a Linux-only static helper
labtool(tests/lab/labtool.zig), built viazig build lab-toolsand wired intobuild.zig, CI cross-compile, and Linux-only unit tests for its parsers.labtoolcovers TCP listeners, UDP echo, service fakes (SSH/FTP/SMTP/DNS/HTTP),wait-tcp, andudp-noise; labs andcapture_bench.shcall it instead of inline Python.tests/lab/services/serve.pyis removed; TLS fakes stay onopenssl s_server. Output checks usejqandxmllintinstead of Python.The HTTP lab fake now advertises
zigmap-lab/1.0; the service matcher test and bridge lab expectations follow. Golden fixture capture docs drop Python in favor of busyboxnc. README documents the new flow.Reviewed by Cursor Bugbot for commit 04febf3. Configure here.