Skip to content

Replace Python lab tooling with a Zig labtool - #4

Merged
mcaney006 merged 1 commit into
mainfrom
lab-tools-in-zig
Nov 18, 2026
Merged

mcaney006 merged 1 commit into
mainfrom
lab-tools-in-zig

Conversation

@mcaney006

@mcaney006 mcaney006 commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

The Docker labs and the capture benchmark used Python for listeners,
service fakes, UDP noise and output checks. They now use:

  • tests/lab/labtool.zig, a static Linux helper built by
    zig build lab-tools (not part of the default install): TCP listeners,
    UDP echo, SSH/FTP/SMTP banners, DNS over TCP and HTTP fakes, UDP noise
    and a wait-for-port helper.
  • openssl s_server for the TLS fake.
  • jq and xmllint to check the JSON, JSONL and XML output.

The HTTP fake now reports "zigmap-lab/1.0", and the service matcher test
uses a lighttpd banner. CI cross-compiles labtool on both runners, and
its parser test runs under zig build test on Linux.

Connect lab, bridge lab and one capture-bench run (ring mode) pass on
Linux aarch64.


Note

Low Risk
Changes affect test/lab infrastructure and CI build steps only, not the scanner binary or production runtime behavior.

Overview
Replaces Python lab dependencies with a Linux-only static helper labtool (tests/lab/labtool.zig), built via zig build lab-tools and wired into build.zig, CI cross-compile, and Linux-only unit tests for its parsers.

labtool covers TCP listeners, UDP echo, service fakes (SSH/FTP/SMTP/DNS/HTTP), wait-tcp, and udp-noise; labs and capture_bench.sh call it instead of inline Python. tests/lab/services/serve.py is removed; TLS fakes stay on openssl s_server. Output checks use jq and xmllint instead of Python.

The HTTP lab fake now advertises zigmap-lab/1.0; the service matcher test and bridge lab expectations follow. Golden fixture capture docs drop Python in favor of busybox nc. README documents the new flow.

Reviewed by Cursor Bugbot for commit 04febf3. Configure here.


Devin Review

The Docker labs and the capture benchmark used Python for listeners,
service fakes, UDP noise and output checks. They now use:

- tests/lab/labtool.zig, a static Linux helper built by
  `zig build lab-tools` (not part of the default install): TCP listeners,
  UDP echo, SSH/FTP/SMTP banners, DNS over TCP and HTTP fakes, UDP noise
  and a wait-for-port helper.
- openssl s_server for the TLS fake.
- jq and xmllint to check the JSON, JSONL and XML output.

The HTTP fake now reports "zigmap-lab/1.0", and the service matcher test
uses a lighttpd banner. CI cross-compiles labtool on both runners, and
its parser test runs under `zig build test` on Linux.

Connect lab, bridge lab and one capture-bench run (ring mode) pass on
Linux aarch64.
@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 11 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 11 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

  • 1 security-sensitive path(s) changed

Paths:

  • .github/workflows/ci.yml

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • CI workflow changes may ship without failure-mode evidence
  • Dependency or CI drift could surface after merge
  • 1 CI or workflow path(s) changed

Paths:

  • .github/workflows/ci.yml
  • src/fingerprint/service.zig
  • tests/lab/services/serve.py

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 11 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 11 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Config Audit

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

  • .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Harness Audit

Commit: 04febf3ae2234d18d3f4b4962235450e201c8d68

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

  • .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T22:13:48.399661Z 04febf3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@gitar-bot

gitar-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@mcaney006
mcaney006 merged commit 64ffb14 into main Nov 18, 2026
6 of 9 checks passed
@mcaney006
mcaney006 deleted the lab-tools-in-zig branch November 18, 2026 22:13

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant