Repository navigation
test: verify all 22 API categories are initialized - #498
Open
priyavrat7 wants to merge 1 commit into
Open
priyavrat7 wants to merge 1 commit into
priyavrat7 wants to merge 1 commit into
Conversation
Add initialization checks for the 12 API categories that were not covered by the existing test. This closes the test coverage gap noted in meraki#485 and ensures a missing category registration is caught by the unit tests. Verified the new coverage by temporarily removing the camera registration and confirming that the test fails as expected. This PR Fixes meraki#497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds initialization checks for all 22 API categories registered by
DashboardAPI.The existing
test_all_api_sections_initializedtest only checked 10 categories. The remaining 12 categories were missing from the initialization assertions.This adds the missing assertions so that a category that is accidentally removed or not initialized in
DashboardAPIwill be caught by the unit tests.Testing
uv run pytest tests/unit -qcameraregistration fromDashboardAPIand confirmed that the new assertion failed as expected.changelog.d/497.fixed.mdas required byCONTRIBUTING.md.Base branch
Opened against
beta, matching PR #485.Related issue
This PR Fixes #497